Skip to content

feat(nestjs): Add code.function.name attribute to function spans for description inference - #24305

Merged
Lms24 merged 2 commits into
developfrom
lms/feat-nestjs-code-function-name-attr
Sep 10, 2026
Merged

Lms24 merged 2 commits into
developfrom
lms/feat-nestjs-code-function-name-attr

Conversation

@Lms24

@Lms24 Lms24 commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

This PR adds the code.function.name attribute to NestJS SDK sentr.op: 'function' spans. Span names are already low cardinality and describe the function name, so adding the attribute for description inference is enough here.

A refreshingly simple change for once ❤️

ref #23954

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.91 kB +0.39% +110 B 🔺
@sentry/browser - with treeshaking flags 27.21 kB +0.37% +100 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 27.1 kB +0.35% +93 B 🔺
@sentry/browser (incl. Tracing) 50.27 kB +2.15% +1.05 kB 🔺
@sentry/browser (incl. Tracing + Span Streaming) 50.28 kB +2.15% +1.06 kB 🔺
@sentry/browser (incl. Tracing, Profiling) 53.26 kB +2.18% +1.13 kB 🔺
@sentry/browser (incl. Tracing, Replay) 89.76 kB +1.13% +998 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 78.86 kB +1.16% +901 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 94.45 kB +1.08% +1.01 kB 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 107.46 kB +1.02% +1.08 kB 🔺
@sentry/browser (incl. Feedback) 46.4 kB +0.23% +106 B 🔺
@sentry/browser (incl. sendFeedback) 33.96 kB +0.29% +96 B 🔺
@sentry/browser (incl. FeedbackAsync) 39.07 kB +0.24% +93 B 🔺
@sentry/browser (incl. Metrics) 29.93 kB +0.36% +105 B 🔺
@sentry/browser (incl. Logs) 30.19 kB +0.34% +101 B 🔺
@sentry/browser (incl. Metrics & Logs) 30.86 kB +0.37% +112 B 🔺
@sentry/react 30.66 kB +0.37% +113 B 🔺
@sentry/react (incl. Tracing) 52.59 kB +2.01% +1.03 kB 🔺
@sentry/vue 36.15 kB +0.28% +99 B 🔺
@sentry/vue (incl. Tracing) 52.53 kB +2.05% +1.05 kB 🔺
@sentry/svelte 28.93 kB +0.32% +91 B 🔺
CDN Bundle 30.64 kB +0.32% +95 B 🔺
CDN Bundle (incl. Tracing) 50.78 kB +2.1% +1.04 kB 🔺
CDN Bundle (incl. Logs, Metrics) 32.92 kB +0.32% +102 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 52.73 kB +2% +1.03 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 73.61 kB +0.19% +135 B 🔺
CDN Bundle (incl. Tracing, Replay) 88.32 kB +1.19% +1.03 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 90.29 kB +1.24% +1.1 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 94.36 kB +1.23% +1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 96.38 kB +1.23% +1.17 kB 🔺
CDN Bundle - uncompressed 90.72 kB +0.29% +257 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 151.68 kB +2.37% +3.51 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.3 kB +0.28% +266 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 157.64 kB +2.28% +3.51 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 226.71 kB +0.19% +417 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 271.25 kB +1.31% +3.49 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 277.2 kB +1.28% +3.49 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 284.95 kB +1.24% +3.49 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 290.89 kB +1.22% +3.49 kB 🔺
@sentry/nextjs (client) 54.91 kB +1.7% +913 B 🔺
@sentry/sveltekit (client) 50.69 kB +2.1% +1.04 kB 🔺
@sentry/core/server 37.08 kB +0.26% +96 B 🔺
@sentry/core/browser 13.66 kB +0.82% +110 B 🔺
@sentry/node 128.42 kB +0.5% +630 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.82 kB +0.26% +205 B 🔺
@sentry/node - without tracing 89.02 kB +0.35% +310 B 🔺
@sentry/node - without channel injection 107.53 kB +0.47% +501 B 🔺
@sentry/aws-serverless 97.41 kB +0.32% +310 B 🔺
@sentry/cloudflare (withSentry) - minified 203.01 kB +0.52% +1.03 kB 🔺
@sentry/cloudflare (withSentry) 505.44 kB +0.55% +2.76 kB 🔺

View base workflow run

@Lms24
Lms24 marked this pull request as ready for review September 10, 2026 15:04
@Lms24
Lms24 requested a review from a team as a code owner September 10, 2026 15:04
@Lms24
Lms24 requested review from mydea and s1gr1d and removed request for a team September 10, 2026 15:04
@Lms24 Lms24 self-assigned this Sep 10, 2026
Comment thread packages/nestjs/src/integrations/wrap-route.ts

@nicohrubec nicohrubec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Lms24
Lms24 merged commit 5569d9a into develop Sep 10, 2026
57 checks passed
@Lms24
Lms24 deleted the lms/feat-nestjs-code-function-name-attr branch September 10, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants