Conversation
msonnb
changed the title
msonnb
changed the title
beforeSendSpan null return warning
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/remove-before-send-span-null-warning
branch
from
September 7, 2026 12:20
9a549b9 to
066c5bd
Compare
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
Co-Authored-By: GPT-6 <codex@openai.com>
msonnb
force-pushed
the
ms/remove-before-send-span-null-warning
branch
from
September 28, 2026 14:21
066c5bd to
9ccb8c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unconditional warning when
beforeSendSpanreturnsnull, saving ~90B (compressed) / ~200B (uncompressed).The type already disallows returning null since v9. Keeps the runtime fallback to the original span for JavaScript callers, with one regression test covering the shared behavior.