test(e2e): Always run create-remix-app-v2 with orchestrion - #23931
Merged
Merged
Conversation
Orchestrion is always used now, so the `INJECT_ORCHESTRION` split in the create-remix-app-v2 E2E app was redundant. It ran as two CI jobs: a default one without orchestrion (DB and build-injection tests skipped) and an orchestrion variant that force-bundled/transformed the instrumented deps, booted real databases and ran everything. Collapse this into a single always-orchestrion run: drop the `sentryTest.variants` block and the `:orchestrion` scripts, add `sentryOrchestrionPlugin()` unconditionally, always boot MySQL/Redis via the Playwright global setup, and remove the `INJECT_ORCHESTRION` skip guards so the DB and build-time injection suites become part of the regular run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFugqE3KWYfwqEfqEbjLsB
mydea
force-pushed
the
feat/e2e-remix-always-orchestrion
branch
from
September 2, 2026 12:00
b7bd3b2 to
4e9ed5a
Compare
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
September 2, 2026 12:09
chargome
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orchestrion is always used now, so the
INJECT_ORCHESTRIONvariant split in thecreate-remix-app-v2E2E app no longer earns its keep. The app previously ran as two CI jobs — a default one (orchestrion plugin off, DB + build-injection tests skipped) and anINJECT_ORCHESTRION=truevariant (force-bundle/transform the instrumented deps at build time, boot real databases, run everything). That left the DB and build-time-injection coverage gated behind one of the two jobs and duplicated the app build for no added signal.This collapses it into a single always-orchestrion run:
sentryTest.variantsblock and thetest:build:orchestrion/test:assert:orchestrionscripts, so the basetest:build/test:assertare the whole story and CI runs one job instead of two.sentryOrchestrionPlugin()unconditionally invite.config.ts.playwright.config.mjs.INJECT_ORCHESTRIONskip guards fromdb.test.tsandbuild-injection.test.tsso those suites merge into the regular run.No coverage is lost: the two previously variant-only suites (runtime DB spans, and build-time diagnostics-channel injection into mysql/ioredis/
@remix-run/server-runtime) now run on every invocation.The
INJECT_ORCHESTRIONmentions underdev-packages/node-integration-testsare descriptive comments rather than variant switches, and are left untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_01SFugqE3KWYfwqEfqEbjLsB