Conversation
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretm
force-pushed
the
awad/route-provider-nuxt
branch
from
September 24, 2026 18:04
0acaa5b to
770e111
Compare
logaretm
force-pushed
the
awad/route-provider-nuxt
branch
from
September 24, 2026 18:14
770e111 to
d4ec85f
Compare
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/route-provider-nuxt
branch
2 times, most recently
from
September 24, 2026 18:50
54f0ca2 to
0766878
Compare
logaretm
force-pushed
the
awad/route-provider-nuxt
branch
from
September 24, 2026 19:11
0766878 to
33c0138
Compare
logaretm
force-pushed
the
awad/route-provider-nuxt
branch
from
September 24, 2026 19:59
33c0138 to
b00dc56
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b00dc56. Configure here.
Nuxt installs the router before its plugins run, so the client plugin can read it straight off `nuxtApp` rather than waiting for a Vue app the way `@sentry/vue` does. Registered outside the `__SENTRY_TRACING__` guard, so route parameterization survives when tracing is tree-shaken away. Reuses `createVueRouteProvider` rather than reimplementing the vue-router resolve handling.
logaretm
force-pushed
the
awad/route-provider-nuxt
branch
from
September 24, 2026 21:20
b00dc56 to
25a1d20
Compare
logaretm
marked this pull request as ready for review
September 24, 2026 21:26
logaretm
requested review from
chargome and
nicohrubec
and removed request for
a team
September 24, 2026 21:26
s1gr1d
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Registers a route provider for Nuxt in the client plugin, outside the
__SENTRY_TRACING__guard.Nuxt installs the router before its plugins run, so the plugin can read it straight off
nuxtApprather than waiting for a Vue app the way@sentry/vuehas to. ReusescreateVueRouteProviderfrom #23553's successor rather than reimplementing the vue-router resolve handling.Because it sits outside the tracing guard, route parameterization survives when tracing is tree-shaken away.
Part of #23556