Conversation
Contributor
size-limit report 📦
|
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretm
force-pushed
the
awad/route-provider-astro
branch
2 times, most recently
from
September 24, 2026 18:14
e2e9043 to
8d918ed
Compare
logaretm
force-pushed
the
awad/route-provider-astro
branch
2 times, most recently
from
September 24, 2026 18:50
e2504e2 to
b3d3aa2
Compare
logaretm
force-pushed
the
awad/route-provider-astro
branch
2 times, most recently
from
September 24, 2026 19:59
47c9fed to
5cca66c
Compare
logaretm
changed the title
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5cca66c. Configure here.
The middleware already injects the parameterized route into the document it renders, but it was only readable from the pageload instrumentation. Registered from `init()` rather than the tracing integration, so route parameterization no longer depends on tracing being enabled. Not a matcher: the document only describes the page it rendered, so a URL other than the current one resolves to undefined rather than a guess. Verified against Astro 5.18 that `ClientRouter` swaps the tag during `astro:after-swap", at the same moment `location` changes, so reading it per call stays correct across soft navigations and back/forward.
logaretm
force-pushed
the
awad/route-provider-astro
branch
from
September 24, 2026 21:20
5cca66c to
bccce36
Compare
logaretm
marked this pull request as ready for review
September 24, 2026 21:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for Astro from the
sentry-route-namemeta tag the middleware already injects into every rendered document.Registered from
init()rather than the tracing integration, so route parameterization no longer depends on tracing being enabled.Unlike the Next.js and Remix providers this is not a matcher. The document only ever describes the page it rendered, so a URL other than the current one resolves to
undefinedrather than a guess. That guard is also what stops a navigation being named after the route it is leaving.I checked the soft-navigation behaviour against Astro 5.18 with a throwaway app rather than assuming it.
ClientRouterswaps the tag duringastro:after-swap, at the same momentlocationchanges, and does not accumulate duplicates, so reading it per call stays correct across client-side navigations and back/forward. It is only stale during a navigation, before the swap, which the current-path guard already excludes.Part of #23556