feat(wasm): patch non-streaming load paths - #23767
Merged
Merged
Conversation
d2anamaria
marked this pull request as draft
August 31, 2026 12:44
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Patch `Response.prototype.arrayBuffer` and `bytes` to tag wasm buffers with `response.url` in a `WeakMap` - Hook `WebAssembly.instantiate` and `compile` to use tagged URL to register module - Skip registration when `instantiate` receives an already-compiled `WebAssembly.Module` - Split `patchWebAssembly` into response, non-streaming, and streaming setup; guard non-streaming with `nonStreamingPatched` - Add `patchWebAssembly.test.ts` for fetch → arrayBuffer → instantiate/compile - Extend `webworker.test.ts` to restore patched globals and assert `instantiate` is hooked
andreiborza
force-pushed
the
ana/feat/wasm-non-streaming
branch
from
August 31, 2026 22:15
3a55a63 to
99a2a60
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2327538. Configure here.
andreiborza
requested review from
logaretm and
msonnb
and removed request for
a team
September 1, 2026 09:25
andreiborza
changed the title
Contributor
|
👋 @andreiborza — Please review this PR when you get a chance! |
Contributor
andreiborza
approved these changes
Sep 7, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Thanks @d2anamaria, looks good!
47 tasks
47 tasks
timfish
added a commit
that referenced
this pull request
Sep 25, 2026
Buffer-compiled wasm (fetch → arrayBuffer → instantiate, common in workers) shows up in Chrome stacks as `wasm://wasm/<name>-<hash>` instead of the fetch URL stored as `code_file`, so frames never link to the debug image and symbolication fails. ## Solution - At registration, read the wasm `name` custom section into an internal `moduleName` on the image. It is stripped before the event is sent. - In `patchFrames()`, when the exact `code_file` lookup misses, compare the label's module name to the registered images. An image with a parsed `moduleName` matches on that name only, because V8 builds the label from the name section and nothing else. An image without one is guessed from the fetch URL basename, including the wasm-bindgen `_bg.wasm` → `.wasm` alias. - Accept a match only when every candidate shares one `debug_id`, since a page and a worker can register the same binary under different URLs. - A label counts as hash-only when no `-<hash>` suffix was stripped, so hex-looking module names such as `ed25519` still map. ## Decisions - Every response body read is tagged with its URL, not only wasm-looking ones. #23767 sniffed content type and file extension, which silently dropped modules served as `application/octet-stream` or from extension-less URLs. A tag is only read back after a `WebAssembly` compile succeeded, so tagging a non-wasm buffer is never observable. Body reads on responses without a URL are passed through untouched. - The browser test loads a new fixture, `named.wasm`, which is `simple.wasm` plus a module-name subsection. `simple.wasm` only carries function names, so Chrome labels it hash-only and the mapping cannot be exercised with it. Code offsets and `build_id` are unchanged. ## Limitations - Hash-only `wasm://wasm/<hex>` labels are not mapped (#23781) - Ambiguous names (same name, different `debug_id`) stay unmatched - Other browsers and unnamed wasm are unchanged --------- Co-authored-by: Andrei Borza <andrei.borza@sentry.io> Co-authored-by: Tim Fish <tim@timfish.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register wasm modules when apps load via
fetch → arrayBuffer → WebAssembly.instantiate/compile, not only streaming APIs.Response.prototype.arrayBufferandbytesso wasm buffers remember their fetch URLWebAssembly.instantiateandcompileto register modules after byte-based loadspatchWebAssembly(register)fetch → arrayBuffer → instantiateRegistration only. Frames from buffer-compiled modules still carry
wasm://wasm/<hash>, which nothing matches against the registered image, sodebug_metadoes not attach yet. That half is #23781.Implementation
patchWasmResponse.tstags wasm buffers in aWeakMapwhen read from a wasm-likeResponse;getWasmSourceUrl()resolves them at instantiate/compile timefill(), so a frozenResponse.prototypecannot breakSentry.init()patchWebAssembly()orchestrates response patching, non-streaming hooks, then streaming hooks (unchanged behavior)instantiatereceives an already-compiledWebAssembly.Module