Repository navigation
chore(deps): Bump OkHttp from 4.9.2 to 5.5.1 (JAVA-715) - #6472
Open
runningcode wants to merge 2 commits into
Open
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
sentry-okhttp and the Spring Boot integrations still compile against okhttp as compileOnly. The okhttp3 members they reference are identical for 4.9.2 and 5.5.1, so OkHttp 4 keeps working at runtime. OkHttp 5 tries IPv6 first and races routes, which surfaced a bug: connectFailed() marked the whole call span INTERNAL_ERROR even when OkHttp then connected on another route. It now only closes the connect timing. callFailed() still reports a call that fails on every route. sentry-apollo and the Android UI tests stay on mockwebserver 4. Apollo 2 passes a null body to Response.Builder.body(), and the UI test APK is pinned to the app's okio 2, while OkHttp 5 needs okio 3. Fixes JAVA-715 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 5, 2026 13:40
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
November 5, 2026 13:40
runningcode
added
the
sanity-check
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Bump to okhttp 5.5.1 from 4.9.2.
This doesn't break anything and also fixes a bug, so we can merge this against the 8.x branch too. That might be best since it lessens the chance of merge conflicts of only having changes on the v9 branch.
sentry-okhttpand the Spring Boot integrations still haveokhttpascompileOnly, so we still use whatever version the apps bring. Okhttp 4 and 5 have the same API.The only change is that this bump revealed a bug in
SentryOkHttpEventListener.connectFailed()marked the whole call spanINTERNAL_ERROR, even though OkHttp retries the next route and often succeeds. OkHttp 5 makes this more common: it tries IPv6 first and races routes (Happy Eyeballs).We still keep the previous mockwebserver split where we have two different test versions but they are both now bumped.. This was probably what was preventing the version bumps before though.
💡 Motivation and Context
OkHttp 5 can combine several
EventListeners (5.3.0+), which we want to build on. The earlier bump (#6464) failed insentry-apolloand the Android UI tests for the reasons above.💚 How did you test it?
Unit tests of every module that uses okhttp, the Spring Boot
integrationTestsuites, and the UI test APK builds with and without integrations. New tests inSentryOkHttpEventListenerTestcover a call that recovers from a failed route and a call that fails on every route.📝 Checklist
sendDefaultPIIis enabled.🤖 Generated with Claude Code