Repository navigation
ci: Remove the dead submodules checkout option - #6447
Open
runningcode wants to merge 1 commit into
Open
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
The repository has had no submodules since the NDK moved to sentry-native (#3189), which left `.gitmodules` empty. The `submodules: 'recursive'` input on our checkout steps has been a no-op since, so drop it along with the empty file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 2, 2026 14:53
runningcode
requested review from
0xadam-brown and
markushi
and removed request for
a team
November 2, 2026 14:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removes
submodules: 'recursive'from theactions/checkoutsteps in 11 workflows, along with anywith:block that ends up empty. It also deletes the empty.gitmodulesfile.The repository has no submodules:
git ls-tree -ronmainfinds no gitlink entries, and nothing reads.gitmodules. The only submodule,sentry-android-ndk/sentry-native, went away when the NDK moved to sentry-native in #3189. Since then the option has done nothing, and it keeps getting copied into new workflows.Other checkout inputs don't change.
build.ymlkeepsref: ${{ github.event.pull_request.head.sha || github.sha }}, which its snapshot upload needs.💡 Motivation and Context
Came up while reviewing the new Samples workflow in #6392, which had copied the option from
build.yml.💚 How did you test it?
actionlintpasses on all changed workflows.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog
🤖 Generated with Claude Code