Repository navigation
ci(samples): [Sample Tests 48] Run the Android builds' checks in their own workflow - #6446
Closed
runningcode wants to merge 1 commit into
Closed
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
The Android sample and integration test builds ran their `check` inside the SDK's Build job via `make preMerge`, one after the other. A new Samples workflow runs each build in its own matrix job, so a broken sample fails its own check, the builds run in parallel, and the Build job gets shorter. `preMerge` is back to the root `check`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
📲 Install BuildsAndroid
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)On hold, off the stack: #6394 (base: #6393) moves the JVM samples to their own build. We haven't decided what to do with them yet.
📜 Description
A new
Samplesworkflow runscheckin the two Android builds the SDK build doesn't include. There is one matrix job each forsentry-samples/sentry-samples-androidandsentry-android-integration-tests, withfail-fast: false. Each job uploads its own reports and JUnit summary, the same way the Build job does.make preMergeis back to just the rootcheck. ThecheckSampleAndroidandcheckIntegrationTeststargets from #6392 and #6393 are removed.format-code.ymlandmake checkFormatdon't change. Spotless also runs as part of each build'scheck.💡 Motivation and Context
Until now, #6392 and #6393 ran each build's
checkone after the other insideBuild Job ubuntu-latest. With its own workflow:The trade-off is more total runner minutes. Each job compiles the SDK modules its build depends on, but doesn't run their tests.
This replaces #6444, which also had a job for the JVM samples and was stacked on #6394.
Part of the Linear project "Separate sample projects and tests from build." (JAVA-626).
💚 How did you test it?
actionlintpasses on the new workflow. The Samples jobs on this PR are the real test.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The main branch ruleset doesn't require the new
Check <build>jobs yet, so for now they don't block merges. Requiring them takes an admin to add them to the ruleset.If #6394 goes ahead, it adds a
sentry-samplesentry to this matrix instead of itscheckSamplesMakefile target.#skip-changelog
🤖 Generated with Claude Code