Repository navigation
ref(core): [Tracing API Cleanup 1] Remove deprecated Instrumenter option - #6252
Merged
Merged
Conversation
Remove the Instrumenter enum and its tracing configuration now that OpenTelemetry no longer depends on instrumenter selection. Simplify span creation to use SpanOptions for explicit start timestamps. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
adinauer
commented
Oct 13, 2026
| public fun startChild (Ljava/lang/String;)Lio/sentry/ISpan; | ||
| public fun startChild (Ljava/lang/String;Ljava/lang/String;)Lio/sentry/ISpan; | ||
| public fun startChild (Ljava/lang/String;Ljava/lang/String;Lio/sentry/SentryDate;)Lio/sentry/ISpan; | ||
| public fun startChild (Ljava/lang/String;Ljava/lang/String;Lio/sentry/SentryDate;Lio/sentry/Instrumenter;)Lio/sentry/ISpan; |
Member
Author
There was a problem hiding this comment.
These are marked internal on ISpan
4 of 9 tasks
adinauer
marked this pull request as ready for review
October 19, 2026 12:33
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
October 19, 2026 12:33
adinauer
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 27, 2026
List the OpenTelemetry integration and instrumenter APIs removed in v9 and direct readers to the supported Java OpenTelemetry documentation. Refs getsentry/sentry-java#6243 Refs getsentry/sentry-java#6252 Co-Authored-By: Claude <noreply@anthropic.com>
1 of 6 tasks
Keep the OpenTelemetry classes removed by the base branch and retain both breaking-change entries in the changelog.
markushi
reviewed
Oct 29, 2026
markushi
left a comment
markushi
left a comment
Member
There was a problem hiding this comment.
Nice one! I do have one concern I'd like to get addressed, but otherwise LGTM!
| finishAppStartSpan(); | ||
| } | ||
| } | ||
| spanOptions.setStartTimestamp(ttidStartTime); |
Member
There was a problem hiding this comment.
m: Could you duplicate the spanOptions here? One for appStartSpan and one for the ttidSpan. I feel like otherwise it's super brittle as we're mutating the options, and there's no guarantee that appStartTime won't read the mutated options at a later point.
Member
There was a problem hiding this comment.
As discussed, let's improve this outside the PR.
markushi
approved these changes
Oct 29, 2026
Preserve the timestamp-and-options startChild call shape while removing Instrumenter. Keep integration call sites close to their previous form instead of setting timestamps directly on SpanOptions. Co-Authored-By: Claude <noreply@anthropic.com>
6 of 9 tasks
adinauer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Tracing API Cleanup)
📜 Description
Removes the deprecated
Instrumenterconfiguration and related tracing code for Java SDK 9:Instrumenterenum andSentryOptionsoptionSpanContextISpan.startChildoverloads and filteringSpanOptionsfor explicit start timestampsThis complements #6243, which removes the deprecated OpenTelemetry implementations that originally required instrumenter selection.
💡 Motivation and Context
The current OpenTelemetry integration no longer relies on choosing between
SENTRYandOTELinstrumenters. Keeping this deprecated option adds public API and conditional tracing paths without a supported use case. Java SDK 9 is the appropriate breaking-change boundary for removing it.💚 How did you test it?
./gradlew spotlessApply apiDump./gradlew ':sentry:test' ':sentry-android-core:testReleaseUnitTest' ':sentry-android-sqlite:testReleaseUnitTest' ':sentry-compose:testReleaseUnitTest' ':sentry-opentelemetry:sentry-opentelemetry-core:test' ':sentry-opentelemetry:sentry-opentelemetry-bootstrap:test' --info📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.