Repository navigation
chore: fix the iOS device tests and other leftovers from the version7 sync - #5837
Merged
Merged
Conversation
EF Core 11 RC 3 brings in Microsoft.Data.SqlClient 7.1.0, which resolves System.Security.Cryptography.Pkcs 9.0.18, and GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7 cover that version. #5771 pinned it for net10.0. The weekly vulnerability scan only runs on main, so net11.0 would only show up once version7 merges into main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sentry.Maui.Tests references Sentry.Extensions.Hosting and runs on device, but neither device test workflow listed it in its path filter. A PR that only changed Sentry.Extensions.Hosting skipped the device tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version7 #5837 +/- ##
============================================
- Coverage 76.76% 76.76% -0.01%
============================================
Files 539 539
Lines 19694 19694
Branches 3851 3851
============================================
- Hits 15119 15118 -1
Misses 3703 3703
- Partials 872 873 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The main→version7 merge (11b5491) kept both sides' copy of the Cocoa cache steps. The ios-tests job in device-tests-ios.yml got "Get Cocoa SDK cache key" and "Restore Cocoa SDK" twice, and GitHub rejects a workflow whose steps repeat an id, so the iOS device tests haven't run on version7 since. The build-sentry job in build.yml got "Save Cocoa SDK" twice in a row. That one has no id, so it only tried to save the same key a second time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ric-oliv
changed the title
bitsandfoxes
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftovers from the main→version7 sync in #5834.
ios-testsjob ofdevice-tests-ios.yml. GitHub rejects a workflow whose steps repeat an id, so the iOS device tests haven't run onversion7since the sync. The same merge left two identical "Save Cocoa SDK" steps inbuild.yml. This removes the second copy of each.System.Security.Cryptography.Pkcsfor the net10.0 tests inSentry.DiagnosticSource.IntegrationTests. The net11.0 tests have the same problem: EF Core 11 RC 3 brings inMicrosoft.Data.SqlClient7.1.0, which resolves Pkcs 9.0.18, and GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7 cover that version. The weekly vulnerability scan only runs onmain, so we'd only find out onceversion7merges intomain. With the pin,scripts/check-vulnerabilities.ps1finds nothing in the project. It uses the RC 3 version, so the next RC bump updates it along with EF Core.Sentry.Maui.TestsreferencesSentry.Extensions.Hostingand runs on device, but neither device test workflow listed that project. A PR that only changedSentry.Extensions.Hostingskipped the device tests.#skip-changelog