Skip to content

fix: drop attachments whose stream turns out empty when the envelope is sent - #5787

Merged
bitsandfoxes merged 4 commits into
mainfrom
fix/drop-empty-attachments
Oct 28, 2026
Merged

bitsandfoxes merged 4 commits into
mainfrom
fix/drop-empty-attachments

test: assert dropped attachments leave no blank line in the envelope

dac0cdd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 28, 2026 in 1s

76.15% (+0.02%) compared to ff0355e

View this Pull Request on Codecov

76.15% (+0.02%) compared to ff0355e

Details

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.15%. Comparing base (ff0355e) to head (dac0cdd).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/Sentry/Protocol/Envelopes/EnvelopeItem.cs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
+ Coverage   76.13%   76.15%   +0.02%     
==========================================
  Files         528      528              
  Lines       19579    19590      +11     
  Branches     3829     3835       +6     
==========================================
+ Hits        14906    14919      +13     
+ Misses       3791     3790       -1     
+ Partials      882      881       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.