Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
The plan checks errors on the changed guide pages, loads of those pages, and site error volume. An issue escalates when those page errors appear or site errors rise. Services: Mention PlanWhat changedThe NestJS Cron decorator docs now describe auto monitor config from RiskWrong MDX can fail both pages that share this include. A broken code block can fail the shared code tab on those pages. Readers can then miss how to create a monitor from Intended effectThis change is a docs edit. No queryable signal shows the new section is live. Regression watchThis include ships on the NestJS Cron decorator page and the NestJS crons setup page. A render fault would show as errors or a drop in NestJS guide loads.
The 24h p95 may include slow navigations. Escalate when NestJS guide errors leave zero or site errors leave the hourly band. Not observableWhether the new heading is visible on the published pages. Traffic on the sentry-cron-decorator page alone had no traces in this window. Whether the JavaScript SDK ships the 11.5.0 Cron behavior. |
| ``` | ||
|
|
||
| If `@Cron` has no `timeZone`, the job runs in your server's local time zone, so that time zone is sent. | ||
|
|
||
| A six-field expression is sent without its seconds field if that field is a single number, such as `0 30 9 * * *`. Presets such as `@daily` and `@weekly` are sent too. Sub-minute schedules, `Date` values, `utcOffset`, numeric months (use names such as `MAY`), a `*/n` day field combined with the other day field, and time zones that aren't IANA names send no monitor config, including any other options you pass. In those cases, pass a full monitor config to `@SentryCron` or create the monitor in Sentry first. | ||
|
|
||
| To send check-ins without a monitor config, pass `{ fromCronDecorator: false }`. |
There was a problem hiding this comment.
Bug: The documentation for fromCronDecorator: false is for an unreleased SDK feature and may become incorrect if the final implementation uses a different name.
Severity: MEDIUM
Suggested Fix
Confirm the final property name from the corresponding SDK implementation (sentry-javascript PR #25013) once it has been released. It is recommended to merge this documentation change only after the SDK feature is shipped to ensure accuracy.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: includes/nestjs-sentry-cron-decorator.mdx#L50-L56
Potential issue: The documentation introduces the `fromCronDecorator: false` option,
which is tied to an unreleased SDK feature (version 11.5.0). The pull request notes that
this documentation should only be merged after the SDK feature ships. Because the
feature is not yet released, the final property name in the SDK might differ. If the
name changes, the documentation will be incorrect, and users attempting to use
`fromCronDecorator: false` will find that it has no effect, causing confusion.
Did we get this right? 👍 / 👎 to inform future reviews.
DESCRIBE YOUR PR
Documents that
@SentryCronnow sends the schedule and time zone of@Cronon the same method, so check-ins create the monitor. Covers the server time zone default, which schedules send no config, and thefromCronDecorator: falseopt-out.SDK change: getsentry/sentry-javascript#25013. Merge after it ships; the page marks it as available since 11.5.0, which assumes it lands in the next minor.
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST