refactor(js): use browser-only/server-only directly in getPlatformHints - #19496
Merged
mydea merged 1 commit intoSep 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
Priority: Needs Triage
mydea
added this pull request to stack #19507
September 18, 2026 10:24
6 tasks
github-actions
Bot
added
Priority: Normal
mydea
marked this pull request as ready for review
September 18, 2026 10:48
mydea
force-pushed
the
guide-cat/05-platform-hints
branch
from
September 18, 2026 10:49
9ac0caa to
a35dfe3
Compare
chargome
approved these changes
Sep 21, 2026
Replace the current-platform runtime check in getPlatformHints with direct `isBrowserOnly` / `isServerOnly` category checks. The "Only available on: Client/Server" hint is only informative on dual-runtime (meta-framework) platforms; on a single-runtime platform the option's runtime is already implied, so we suppress it there. Note: this also surfaces the hint on `desktop` platforms (electron), which carry neither `browser-only` nor `server-only` — electron runs both a browser (renderer) and a Node (main) runtime, so the runtime note is appropriate there. Previously it was suppressed on electron because it lacked an explicit `browser`/`server` tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
guide-cat/05-platform-hints
branch
from
September 21, 2026 08:06
a35dfe3 to
2c22ada
Compare
mydea
added a commit
that referenced
this pull request
Sep 21, 2026
## DESCRIBE YOUR PR > **Stacked PR.** Part of the JavaScript guide-categories series (#19492 → #19506). Depends on #19496; review/merge bottom-up. Add `supportedCategories` / `notSupportedCategories` frontmatter fields that gate common-content inheritance by platform category, alongside the existing guide-name `supported` / `notSupported` lists. - A page with `supportedCategories` is shown only for platforms/guides whose categories match; `notSupportedCategories` hides matching ones. - Lets pages target e.g. all server SDKs with `notSupportedCategories: [browser]` instead of enumerating every framework, and auto-covers new guides. - Both `isSupported` implementations (doc-tree collector and search collector) resolve categories and apply the new lists. Covered by `commonContentInheritance.spec.ts`. - This is the feature the remaining PRs in the stack build on. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the due date. You can update this information later by editing the PR description. - [ ] Urgent deadline (GA date, etc.): YYYY-MM-DD - [ ] Other deadline: YYYY-MM-DD - [x] No deadline: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've supplied a deadline. Thanks in advance for your help! ## PRE-MERGE CHECKLIST _Make sure you've checked the following before merging your changes:_ - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Key the “Only available on: Client/Server” hint in
getPlatformHintsoff the newisBrowserOnly/isServerOnlycategory checks instead of hand-rolled runtime detection.desktop(electron), which runs both a browser and a Node runtime.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code