Repository navigation
feat(flutter): Report cellular network technology - #4066
Merged
Merged
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. FeaturesFlutter
FixesFlutter
Other
DependenciesDeps
Internal Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
==========================================
+ Coverage 88.80% 92.94% +4.14%
==========================================
Files 348 114 -234
Lines 12631 4636 -7995
==========================================
- Hits 11217 4309 -6908
+ Misses 1414 327 -1087
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
alwx
marked this pull request as ready for review
October 7, 2026 13:56
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
alwx
force-pushed
the
feat/connection-effective-type
branch
from
October 12, 2026 11:21
e9c2485 to
a330a0a
Compare
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a8dc49 | 362.43 ms | 361.82 ms | -0.61 ms |
| 1777727 | 438.67 ms | 447.11 ms | 8.44 ms |
| cdf371b | 367.64 ms | 377.02 ms | 9.38 ms |
| 1fff351 | 423.68 ms | 408.96 ms | -14.72 ms |
| 1e46846 | 419.06 ms | 429.65 ms | 10.59 ms |
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
| 98b29fe | 406.81 ms | 446.74 ms | 39.93 ms |
| 694da33 | 406.30 ms | 403.51 ms | -2.79 ms |
| 3f47ea3 | 368.20 ms | 388.14 ms | 19.94 ms |
| d5a1225 | 377.37 ms | 366.56 ms | -10.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a8dc49 | 14.77 MiB | 16.08 MiB | 1.31 MiB |
| 1777727 | 14.30 MiB | 15.49 MiB | 1.19 MiB |
| cdf371b | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 1fff351 | 14.31 MiB | 15.49 MiB | 1.19 MiB |
| 1e46846 | 14.31 MiB | 15.56 MiB | 1.25 MiB |
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 98b29fe | 14.55 MiB | 15.87 MiB | 1.31 MiB |
| 694da33 | 14.31 MiB | 15.49 MiB | 1.19 MiB |
| 3f47ea3 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| d5a1225 | 14.31 MiB | 15.49 MiB | 1.19 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a69a51f | 1231.73 ms | 1233.15 ms | 1.42 ms |
| e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
| 98188da | 1252.31 ms | 1251.41 ms | -0.90 ms |
| ebccb5b | 1245.39 ms | 1249.31 ms | 3.92 ms |
| 0265ce5 | 1261.66 ms | 1250.42 ms | -11.24 ms |
| 6b69699 | 1254.80 ms | 1273.31 ms | 18.52 ms |
| caa8620 | 1261.15 ms | 1262.62 ms | 1.46 ms |
| d2356d0 | 1257.04 ms | 1257.94 ms | 0.89 ms |
| 6287dc4 | 1262.46 ms | 1241.96 ms | -20.50 ms |
| cd94e79 | 1266.86 ms | 1252.40 ms | -14.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a69a51f | 5.53 MiB | 6.01 MiB | 487.38 KiB |
| e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 98188da | 5.83 MiB | 6.28 MiB | 459.62 KiB |
| ebccb5b | 5.53 MiB | 5.96 MiB | 444.86 KiB |
| 0265ce5 | 5.66 MiB | 6.09 MiB | 448.36 KiB |
| 6b69699 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| caa8620 | 5.73 MiB | 6.17 MiB | 455.47 KiB |
| d2356d0 | 5.66 MiB | 6.09 MiB | 448.38 KiB |
| 6287dc4 | 5.53 MiB | 5.96 MiB | 444.81 KiB |
| cd94e79 | 5.83 MiB | 6.28 MiB | 459.39 KiB |
sentry-cocoa 9.30.0 and sentry-android 8.60.0 report the cellular network technology in device.connection_effective_type. The test makes sure that the field and connection_type reach the event from native. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alwx
force-pushed
the
feat/connection-effective-type
branch
from
October 13, 2026 10:07
a330a0a to
e3a81c5
Compare
buenaflor
reviewed
Oct 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@buenaflor done! |
…/sentry-dart into feat/connection-effective-type
buenaflor
approved these changes
Oct 16, 2026
This was referenced Oct 22, 2026
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Events report the generation of the cellular network technology in
device.connection_effective_typeon Android and iOS, for example4gor5g. The native SDKs produce the field, and this SDK passes it on without code changes. This pull request adds a test that makes sure thatconnection_typeandconnection_effective_typereach the event from the native contexts.💡 Motivation and Context
Closes #2435. sentry-cocoa 9.30.0 (getsentry/sentry-cocoa#9097) and sentry-android 8.60.0 (getsentry/sentry-java#6146) add the field.
💚 How did you test it?
A unit test in
load_contexts_integration_test.dart.📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Merge this pull request after the bumps to sentry-cocoa 9.30.0 and sentry-android 8.60.0. The base is
v10-branch, becausemainuses sentry-cocoa 8.Changelog Entry
device.connection_effective_typeon Android and iOS, for example4gor5g. On Android 11 and earlier, the app must have theREAD_PHONE_STATEpermission.