Repository navigation
fix(attributes): Describe pageload links for cache_origin and server_request - #789
Merged
Merged
Conversation
…er_request` A pageload span of a reused page links the span that rendered the reused part with `cache_origin`. The briefs did not cover that case, so `server_request` could look like the right type for it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
s1gr1d
marked this pull request as ready for review
November 9, 2026 16:29
s1gr1d
requested review from
a team,
Lms24,
alexander-alderman-webb,
andreiborza,
cleptric,
giortzisg,
mjq and
nsdeschenes
as code owners
November 9, 2026 16:29
andreiborza
approved these changes
Nov 11, 2026
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just clarifying the attributes better.
A pageload span of a reused page (
page.server_rendering.typeisstaticorpartially_static) links the span that rendered the reused part withcache_origin. The briefs did not cover this case, soserver_requestcould look like the right type for it.server_requestis only for the request of the current page load, when its trace context arrived too late to continue. The two types can be on the same pageload span. The JavaScript SDK sets both in@sentry/nextjs(getsentry/sentry-javascript#25142, getsentry/sentry-javascript#25318).Docs for those attributes: getsentry/sentry-docs#20112