Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions javascript/sentry-conventions/src/attributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3477,6 +3477,7 @@ export type BROWSER_VERSION_TYPE = string;
* Attribute defined in OTEL: No
* Visibility: public
*
* @deprecated - The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the CLS value is final, so there is no report event to record. No replacement.
* @example "navigation"
*/
export const BROWSER_WEB_VITAL_CLS_REPORT_EVENT = 'browser.web_vital.cls.report_event';
Expand Down Expand Up @@ -3712,6 +3713,7 @@ export type BROWSER_WEB_VITAL_LCP_RENDER_TIME_TYPE = number;
* Attribute defined in OTEL: No
* Visibility: public
*
* @deprecated - The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the LCP value is final, so there is no report event to record. No replacement.
* @example "pagehide"
*/
export const BROWSER_WEB_VITAL_LCP_REPORT_EVENT = 'browser.web_vital.lcp.report_event';
Expand Down Expand Up @@ -16106,7 +16108,7 @@ export type SENTRY_REPLAY_IS_BUFFERING_TYPE = boolean;
* Attribute defined in OTEL: No
* Visibility: public
*
* @deprecated - The report event is now recorded as a browser.web_vital.lcp.report_event or browser.web_vital.cls.report_event attribute. No backfill required.
* @deprecated - The report event moved to browser.web_vital.lcp.report_event and browser.web_vital.cls.report_event, which are themselves deprecated without a replacement. No backfill required.
* @example "pagehide"
*/
export const SENTRY_REPORT_EVENT = 'sentry.report_event';
Expand Down Expand Up @@ -23596,7 +23598,18 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
isInOtel: false,
visibility: 'public',
example: 'navigation',
changelog: [{ version: '0.5.0', prs: [319], description: 'Added browser.web_vital.cls.report_event attribute' }],
deprecation: {
reason:
'The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the CLS value is final, so there is no report event to record. No replacement.',
},
changelog: [
{
version: 'next',
prs: [642],
description: 'Deprecated browser.web_vital.cls.report_event, which has no replacement',
},
{ version: '0.5.0', prs: [319], description: 'Added browser.web_vital.cls.report_event attribute' },
],
},
'browser.web_vital.cls.source.<key>': {
brief: 'The HTML elements or components responsible for the layout shift. <key> is a numeric index from 1 to N',
Expand Down Expand Up @@ -23726,7 +23739,18 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
isInOtel: false,
visibility: 'public',
example: 'pagehide',
changelog: [{ version: '0.5.0', prs: [319], description: 'Added browser.web_vital.lcp.report_event attribute' }],
deprecation: {
reason:
'The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the LCP value is final, so there is no report event to record. No replacement.',
},
changelog: [
{
version: 'next',
prs: [642],
description: 'Deprecated browser.web_vital.lcp.report_event, which has no replacement',
},
{ version: '0.5.0', prs: [319], description: 'Added browser.web_vital.lcp.report_event attribute' },
],
},
'browser.web_vital.lcp.size': {
brief: 'The size of the largest contentful paint element',
Expand Down Expand Up @@ -32561,9 +32585,17 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
example: 'pagehide',
deprecation: {
reason:
'The report event is now recorded as a browser.web_vital.lcp.report_event or browser.web_vital.cls.report_event attribute. No backfill required.',
'The report event moved to browser.web_vital.lcp.report_event and browser.web_vital.cls.report_event, which are themselves deprecated without a replacement. No backfill required.',
},
changelog: [{ version: '0.5.0', prs: [320], description: 'Added sentry.report_event attribute' }],
changelog: [
{
version: 'next',
prs: [642],
description:
'Updated the deprecation reason now that the browser.web_vital.*.report_event attributes are deprecated',
},
{ version: '0.5.0', prs: [320], description: 'Added sentry.report_event attribute' },
],
},
'sentry.sdk.integrations': {
brief:
Expand Down
4 changes: 4 additions & 0 deletions javascript/sentry-conventions/src/search.ts
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,8 @@ export const SEARCH_BROWSER__VERSION = 'browser.version';

/**
* Search name for {@link attributes.BROWSER_WEB_VITAL_CLS_REPORT_EVENT}. `browser.web_vital.cls.report_event`
*
* @deprecated
*/
export const SEARCH_BROWSER__WEB_VITAL__CLS__REPORT_EVENT = 'browser.web_vital.cls.report_event';

Expand Down Expand Up @@ -972,6 +974,8 @@ export const SEARCH_BROWSER__WEB_VITAL__LCP__RENDER_TIME = 'browser.web_vital.lc

/**
* Search name for {@link attributes.BROWSER_WEB_VITAL_LCP_REPORT_EVENT}. `browser.web_vital.lcp.report_event`
*
* @deprecated
*/
export const SEARCH_BROWSER__WEB_VITAL__LCP__REPORT_EVENT = 'browser.web_vital.lcp.report_event';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,17 @@
},
"is_in_otel": false,
"example": "navigation",
"deprecation": {
"reason": "The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the CLS value is final, so there is no report event to record. No replacement.",
"_status": null
},
"visibility": "public",
"changelog": [
{
"version": "next",
"prs": [642],
"description": "Deprecated browser.web_vital.cls.report_event, which has no replacement"
},
{
"version": "0.5.0",
"prs": [319],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,17 @@
},
"is_in_otel": false,
"example": "pagehide",
"deprecation": {
"reason": "The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the LCP value is final, so there is no report event to record. No replacement.",
"_status": null
},
"visibility": "public",
"changelog": [
{
"version": "next",
"prs": [642],
"description": "Deprecated browser.web_vital.lcp.report_event, which has no replacement"
},
{
"version": "0.5.0",
"prs": [319],
Expand Down
7 changes: 6 additions & 1 deletion model/attributes/sentry/sentry__report_event.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,16 @@
"is_in_otel": false,
"example": "pagehide",
"deprecation": {
"reason": "The report event is now recorded as a browser.web_vital.lcp.report_event or browser.web_vital.cls.report_event attribute. No backfill required.",
"reason": "The report event moved to browser.web_vital.lcp.report_event and browser.web_vital.cls.report_event, which are themselves deprecated without a replacement. No backfill required.",
"_status": null
},
"visibility": "public",
"changelog": [
{
"version": "next",
"prs": [642],
"description": "Updated the deprecation reason now that the browser.web_vital.*.report_event attributes are deprecated"
},
{
"version": "0.5.0",
"prs": [320],
Expand Down
29 changes: 27 additions & 2 deletions python/src/sentry_conventions/attributes.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ class _AttributeNamesMeta(type):
"_AWS_REQUEST_ID",
"AWS_REQUEST_URL",
"AWS_REGION",
"BROWSER_WEB_VITAL_CLS_REPORT_EVENT",
"BROWSER_WEB_VITAL_LCP_REPORT_EVENT",
"CLOUDFLARE_D1_QUERY_TYPE",
"CLS_SOURCE_KEY",
"CLS",
Expand Down Expand Up @@ -2404,6 +2406,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
Apply Scrubbing: manual
Defined in OTEL: No
Visibility: public
DEPRECATED: No replacement at this time - The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the CLS value is final, so there is no report event to record. No replacement.
Example: "navigation"
"""

Expand Down Expand Up @@ -2544,6 +2547,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
Apply Scrubbing: manual
Defined in OTEL: No
Visibility: public
DEPRECATED: No replacement at this time - The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the LCP value is final, so there is no report event to record. No replacement.
Example: "pagehide"
"""

Expand Down Expand Up @@ -9481,7 +9485,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
Apply Scrubbing: manual
Defined in OTEL: No
Visibility: public
DEPRECATED: No replacement at this time - The report event is now recorded as a browser.web_vital.lcp.report_event or browser.web_vital.cls.report_event attribute. No backfill required.
DEPRECATED: No replacement at this time - The report event moved to browser.web_vital.lcp.report_event and browser.web_vital.cls.report_event, which are themselves deprecated without a replacement. No backfill required.
Example: "pagehide"
"""

Expand Down Expand Up @@ -14305,7 +14309,15 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
is_in_otel=False,
visibility=Visibility.PUBLIC,
example="navigation",
deprecation=DeprecationInfo(
reason="The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the CLS value is final, so there is no report event to record. No replacement."
),
changelog=[
ChangelogEntry(
version="next",
prs=[642],
description="Deprecated browser.web_vital.cls.report_event, which has no replacement",
),
ChangelogEntry(
version="0.5.0",
prs=[319],
Expand Down Expand Up @@ -14474,7 +14486,15 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
is_in_otel=False,
visibility=Visibility.PUBLIC,
example="pagehide",
deprecation=DeprecationInfo(
reason="The JavaScript SDK stopped setting this in v11. With per-navigation web vitals, web-vitals decides when the LCP value is final, so there is no report event to record. No replacement."
),
changelog=[
ChangelogEntry(
version="next",
prs=[642],
description="Deprecated browser.web_vital.lcp.report_event, which has no replacement",
),
ChangelogEntry(
version="0.5.0",
prs=[319],
Expand Down Expand Up @@ -24769,9 +24789,14 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
visibility=Visibility.PUBLIC,
example="pagehide",
deprecation=DeprecationInfo(
reason="The report event is now recorded as a browser.web_vital.lcp.report_event or browser.web_vital.cls.report_event attribute. No backfill required."
reason="The report event moved to browser.web_vital.lcp.report_event and browser.web_vital.cls.report_event, which are themselves deprecated without a replacement. No backfill required."
),
changelog=[
ChangelogEntry(
version="next",
prs=[642],
description="Updated the deprecation reason now that the browser.web_vital.*.report_event attributes are deprecated",
),
ChangelogEntry(
version="0.5.0",
prs=[320],
Expand Down
Loading