Repository navigation
ref: Extract outgoing trace lookup - #9487
Merged
Merged
Conversation
Move the lookup of the trace propagated to outgoing requests from SentryNetworkTracker into SentryOutgoingTrace: the span bound to the scope if it belongs to a tracer, otherwise the scope's propagation context. Behavior is unchanged. This lets WebView trace propagation reuse the same lookup.
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
7 of 8 tasks
antonis
added
the
run-full-ci
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 725d08b. Configure here.
Size Analysis1 component analyzed iOS Builds
|
📲 Install BuildsiOS
|
antonis
marked this pull request as ready for review
October 29, 2026 10:52
antonis
requested review from
itaybre and
philprime
and removed request for
a team
October 29, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Moves the lookup of the trace propagated to outgoing requests from
SentryNetworkTrackerinto a new internalSentryOutgoingTrace. It returns the span bound to the scope if it belongs to a tracer, otherwise the scope's propagation context, together with the matchingbaggage.Behavior is unchanged.
SentryNetworkTrackeris high-risk code, so this is split out of #9474, which reuses the same lookup for WebView trace propagation.isFromSpanis used by #9474.💡 Motivation and Context
Split out of #9474 to review the
SentryNetworkTrackerchange on its own.💚 How did you test it?
SentryOutgoingTraceTestsfor the propagation context, a tracer, and a child span bound to the scopeSentryNetworkTrackerTestsandSentryNetworkTrackerIntegrationTestspass on macOS and the iOS 26.5 simulator📝 Checklist
sendDefaultPIIis enabled.#skip-changelog