Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7778 +/- ##
=============================================
- Coverage 85.401% 85.398% -0.004%
=============================================
Files 487 487
Lines 29086 29086
Branches 12602 12601 -1
=============================================
- Hits 24840 24839 -1
- Misses 4196 4197 +1
Partials 50 50 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bc00c87 | 1214.34 ms | 1245.67 ms | 31.33 ms |
| b590539 | 1220.42 ms | 1239.82 ms | 19.40 ms |
| 3950d78 | 1212.52 ms | 1243.20 ms | 30.68 ms |
| a47ad66 | 1221.94 ms | 1249.59 ms | 27.66 ms |
| 1a887e2 | 1212.46 ms | 1241.33 ms | 28.87 ms |
| eaeb9bc | 1216.22 ms | 1250.78 ms | 34.56 ms |
| 554a67d | 1225.85 ms | 1254.71 ms | 28.86 ms |
| 6515f11 | 1214.72 ms | 1244.82 ms | 30.10 ms |
| d68691e | 1221.48 ms | 1248.13 ms | 26.65 ms |
| 21cd5ba | 1218.68 ms | 1255.54 ms | 36.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bc00c87 | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| b590539 | 24.14 KiB | 1.12 MiB | 1.09 MiB |
| 3950d78 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| a47ad66 | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| 1a887e2 | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| eaeb9bc | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| 554a67d | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| 6515f11 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| d68691e | 24.14 KiB | 1.12 MiB | 1.09 MiB |
| 21cd5ba | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| var targets: [Target] = [ | ||
| .binaryTarget( | ||
| name: "Sentry", | ||
| url: "https://github.com/getsentry/sentry-cocoa/releases/download/9.9.0/Sentry.xcframework.zip", |
There was a problem hiding this comment.
Bug: The new Package@swift-6.2.swift file is missing from the hardcoded list in the VersionBump script, which will prevent its binary target URLs from being updated during releases.
Severity: HIGH
Suggested Fix
Add Package@swift-6.2.swift to the files array in Utils/VersionBump/main.swift. Consider using a glob pattern to automatically discover Package@swift-*.swift files to prevent this issue in the future.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: Package@swift-6.2.swift#L26
Potential issue: The `VersionBump` utility, used during releases, relies on a hardcoded
list of files to update version numbers. The newly added `Package@swift-6.2.swift` is
not in this list. Consequently, when a new version is released, the binary target URLs
within this file will not be updated and will continue to point to the old `9.9.0`
binaries. While the checksum update script correctly discovers the file, it cannot fix
the stale URLs. This will cause Swift 6.2+ users to silently receive an outdated SDK
version, regardless of the version they specify in their package dependencies.
Did we get this right? 👍 / 👎 to inform future reviews.
📜 Description
Add a newer
Package@swift-6.2.swift, so newer SPM tools use it instead and allow using unsafe flags.💡 Motivation and Context
When using plain SPM, seems like using unsafe flags is disabled when swift tools is lower than 6.1
Fixes: #7738
💚 How did you test it?
Tested it with a sample project and using releases on a fork
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.