Repository navigation
ci: Make the release scripts executable and check script modes in Build - #145
Merged
Merged
Conversation
#137 committed release-preflight.sh and drop-failed-release.sh as 100644. The workflows run them directly, so every automatic Release has failed at "Check what to release" with exit 126 since the merge. Build now fails a PR that adds a non-executable script under .github/scripts.
sentry-junior
Bot
requested review from
BYK,
MathurAditya724 and
betegon
as code owners
November 9, 2026 21:52
BYK
approved these changes
Nov 9, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#137 committed
release-preflight.shanddrop-failed-release.shas mode100644. The workflows run both scripts directly, so every automatic Release since that merge has failed at "Check what to release":The failed Release runs are 42704805104 (
a35d9281), 42705653129 (60dc7cdd) and 42706187193 (a7c10d43). Because of them, the Generated commita7c10d43is still unreleased onmain, and #144 ("Release pipeline failing on main") is open. npm is at 1.58.0, and there is norelease/*branch.Changes
release-preflight.shanddrop-failed-release.shas executable. With this PR, all five scripts in.github/scriptsare100755, including the onesrelease-pipeline-health.ymlcalls:pipeline-issue.sh,drop-failed-release.shandcheck-release-staleness.sh.check-script-modes.sh, which Build runs once, on theBuildmatrix leg, before install. It fails, with an annotation that gives the fix, when any tracked file in.github/scriptsis not100755. That brings this class of bug to the PR instead of the first Release after merge. The scenario tests for ci(release): Release only green builds, release stranded commits, and drop failed releases #137 ran the scripts throughsh, which is why they missed it.Testing
check-script-modes.shfails on today'smain, naming both scripts, and passes on this branch, underdashand when run directly.maingivesproceed=trueand findsa7c10d4 Generatedanda35d928since 1.58.0.actionlintandshellcheck --shell=sh --enable=check-extra-masked-returnspass.After merge
Once Build passes on the merge commit, the automatic Release should release
a7c10d43, probably as 1.59.0. When its Prepare release step succeeds, #144 closes. No manual release is needed.No UI changes, so no screenshots.
--
View Session in Sentry