Skip to content

fix: Distinguish invalid upload tokens and warn about ephemeral encryption - #687

Merged
jan-auer merged 1 commit into
mainfrom
fix/upload-token-errors
Oct 15, 2026
Merged

jan-auer merged 1 commit into
mainfrom
fix/upload-token-errors

Conversation

@jan-auer

@jan-auer jan-auer commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Resumable upload tokens that cannot be decrypted or authenticated now return 400 with a generic error. Unknown sessions and object mismatches retain 404.

Startup emits a warning when persistent encryption keys are absent. The existing logging integration sends this warning to Sentry.

Ref FS-571

@jan-auer
jan-auer requested a review from a team as a code owner October 14, 2026 16:12
@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

FS-571

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.35%. Comparing base (61a8752) to head (48ad0cd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
objectstore-service/src/error.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files         117      117           
  Lines       24173    24201   +28     
=======================================
+ Hits        22082    22109   +27     
- Misses       2091     2092    +1     
Components Coverage Δ
Rust Backend 94.83% <95.00%> (+<0.01%) ⬆️
Rust Client 81.70% <ø> (ø)
Python Client 93.81% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer merged commit a80c2ea into main Oct 15, 2026
25 checks passed
@jan-auer
jan-auer deleted the fix/upload-token-errors branch October 15, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants