Skip to content

fix(gcs): Set content length on empty resumable requests - #686

Merged
jan-auer merged 1 commit into
mainfrom
fix/gcs-resumable-length
Oct 14, 2026
Merged

jan-auer merged 1 commit into
mainfrom
fix/gcs-resumable-length

Conversation

@jan-auer

@jan-auer jan-auer commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

GCS rejects resumable upload offset queries without Content-Length: 0 with HTTP 411. This prevents tiered storage from writing the final chunk.

Offset queries and cancellation requests now explicitly send Content-Length: 0, matching Google’s documentation for status queries and cancellation. The emulator does not enforce this requirement, which is why this is not detected in tests.

Fixes OBJECTSTORE-41P

@jan-auer
jan-auer requested a review from a team as a code owner October 14, 2026 13:07
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.34%. Comparing base (25644d5) to head (cc5781e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   91.34%   91.34%   -0.01%     
==========================================
  Files         117      117              
  Lines       24171    24173       +2     
==========================================
+ Hits        22080    22081       +1     
- Misses       2091     2092       +1     
Components Coverage Δ
Rust Backend 94.82% <100.00%> (+<0.01%) ⬆️
Rust Client 81.70% <ø> (ø)
Python Client 93.81% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer merged commit 61a8752 into main Oct 14, 2026
25 checks passed
@jan-auer
jan-auer deleted the fix/gcs-resumable-length branch October 14, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants