Skip to content

fix(metrics): Preserve backend tags on failed operations - #685

Merged
jan-auer merged 1 commit into
mainfrom
fix/backend-latency-tags
Oct 15, 2026
Merged

jan-auer merged 1 commit into
mainfrom
fix/backend-latency-tags

Conversation

@jan-auer

@jan-auer jan-auer commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

When a backend call fails or times out, latency metrics lack backend tags because the tags were added only after success.

Backend tags are now set before storage operations run and updated when reads or deletes follow a long-term tombstone. Multipart latency metrics also include backend tags. PUT tags remain absent until its route is known.

Ref INC-2579

@jan-auer
jan-auer requested a review from a team as a code owner October 13, 2026 13:25
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

INC-2579

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.34%. Comparing base (81dbdc8) to head (569b6bd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
+ Coverage   91.33%   91.34%   +0.01%     
==========================================
  Files         117      117              
  Lines       24171    24179       +8     
==========================================
+ Hits        22077    22087      +10     
+ Misses       2094     2092       -2     
Components Coverage Δ
Rust Backend 94.82% <100.00%> (+<0.01%) ⬆️
Rust Client 81.70% <ø> (ø)
Python Client 93.81% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer merged commit 5c38787 into main Oct 15, 2026
25 checks passed
@jan-auer
jan-auer deleted the fix/backend-latency-tags branch October 15, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants