Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 91.38% 91.37% -0.01%
==========================================
Files 117 117
Lines 24056 24056
==========================================
- Hits 21983 21982 -1
- Misses 2073 2074 +1
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
This is wrong, we still need to record the payload for GC, as done in #673. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report resumable upload marker creation and successful deletion through the existing
ChangeStreamin the Bigtable and in-memory HV backends.Note that the ID we send through is the same as the LT revision, but the
shared_resource_idfor the records will be different, therefore there cannot be a clash.Please let me know if we should do this differently.
Earlier I've opened #673 which also introduced a new kind of record for resumables and sends those through on creation and completion/cancellation.
It turns out that we might not need that for GC after all (based on yesterday's meeting), moreover GCS doesn't actually bill you for storage for incomplete resumable, so that would not even be correct from a COGS perspective.
Closes FS-563