fix(grep): Handle ripgrep literal newline regex error - #1885
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a user provided a regex pattern to the
greptool that contained a literal newline character (e.g.,foo\nbar), ripgrep would fail with the errorrg: the literal "\n" is not allowed in a regex.This error was not specifically caught by the existing regex error handler in
packages/junior/src/chat/tools/sandbox/grep.ts(line ~337), which only matched/regex parse error|error parsing regex/i. As a result, the error would fall through to a genericthrow new Error(...), leading to an unhandled generic error instead of a user-friendlyToolInputError.This change extends the regex error pattern in
grep.tsto also include|is not allowed in a regex, ensuring that this specific ripgrep error is now correctly identified and converted into aToolInputError. A new test case has been added topackages/junior/tests/unit/tools/sandbox/file-tools.test.tsto cover this scenario.Fixes JUNIOR-7M
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.