Skip to content

fix(slack): Preserve thread reaction users - #1884

Merged
dcramer merged 2 commits into
mainfrom
fix/slack-thread-reaction-users
Sep 18, 2026
Merged

dcramer merged 2 commits into
mainfrom
fix/slack-thread-reaction-users

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Slack thread reads discarded reaction metadata. Strict tool schemas also forced placeholder values for optional inputs, which caused invalid cursor loops.

Preserve reaction names, counts, and user IDs in thread results. Accept null for optional coordinates and pagination inputs so providers do not need placeholders.

via David Cramer.

--

View Junior Session [Sentry]

Co-Authored-By: David Cramer <david@sentry.io>
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
junior-docs Ready Ready Preview Sep 18, 2026 2:07pm UTC

Request Review

Co-Authored-By: David Cramer <david@sentry.io>
@sentry-junior sentry-junior Bot changed the title fix(slack): Return thread reaction users fix(slack): Preserve thread reaction users Sep 18, 2026
@dcramer
dcramer marked this pull request as ready for review September 18, 2026 14:15
@github-actions github-actions Bot added the risk: high PR risk score: high label Sep 18, 2026
@dcramer
dcramer merged commit a5d6f4a into main Sep 18, 2026
43 checks passed
@dcramer
dcramer deleted the fix/slack-thread-reaction-users branch September 18, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant