Repository navigation
fix(changelog): Credit PR commit co-authors when the merge commit has none - #970
Merged
Merged
Conversation
… none Co-Authored-By: Burak Yigit Kaya <126780+BYK@users.noreply.github.com>
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 77cefbc. Configure here.
BYK
approved these changes
Nov 7, 2026
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release changelogs credit co-authors only from the
Co-authored-bytrailers on the commit that landed on the base branch. When a squash merge clears or replaces the default message, those trailers are lost even though every PR commit still has them, and the entry credits only the PR author.This dropped credit for most of getsentry/junior 0.284.0. Its PRs are authored by
sentry-juniorand credit the requester through trailers on each commit. Some squash commits kept the full message (e.g.f98c1907for #2795 →by @thomasjiangcy with @sentry-junior). Others landed as title-only commits (e.g.7315e3f2for #2804 →by @sentry-junior).Now, when the merged commits of a PR list no co-authors, Craft reads the authors of the PR's commits, the same data the PR preview already uses.
fetchPRCoAuthorsnow takes several PRs and reads them with aliasedpullRequestqueries, 25 per request. If a number is not a PR, the query fails, but the PRs it did resolve are still used from the partialdata. PRs whose merged commit already has co-authors make no extra request.Cost: a release now makes one extra GraphQL request for every 25 PRs that have no co-authors on their merged commit.
via @BYK.
--
View Session [Sentry]