fix: pass BASE_TEST_ENV to the coverage target - #1183
Open
vladch-outreach wants to merge 1 commit into
Open
Conversation
The coverage target hand-rolled its environment with only GOPROXY and GOPRIVATE, so TEST_TAGS was never exported. shell/test.sh defaults it to empty, meaning make coverage ran untagged while make test and test-e2e did not. Untagged builds exclude or_test-gated files, so any package whose tests reach a tagged dependency fails to compile and is dropped from the coverage run, under-reporting coverage for every Go service.
|
Link to code coverage report (posted by coverbot 🤖) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coveragehand-rolled its environment with onlyGOPROXY/GOPRIVATE, soTEST_TAGSnever reachedtest.sh, which defaults it to empty.make coveragetherefore ran untagged whiletestandtest-e2edid not, dropping any package whose tests reach anor_test-gated dependency out of the coverage run.docs/makefile.mdalready documents the default asor_test.Why:
searchproxy/internal/searchproxy/server_test.goexcludes itself from coverage builds and cites this gap by name.