Skip to content

fix(macos): serve ONNX Runtime from a build that respects the 13.0 floor #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EtienneLescot merged 1 commit into from
Sep 4, 2026
Merged

fix(macos): serve ONNX Runtime from a build that respects the 13.0 floor #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/build-onnxruntime-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ name: Build ONNX Runtime (macOS 13 floor)
on:
workflow_dispatch:
push:
# BRANCHES ONLY. Without this, pushing a tag matches too — and publishing the
# artifact under `v0.0.0-onnxruntime-1.27.1` started a fresh 22-minute build of
# the very thing that had just been attached to the release.
branches:
- main
paths:
- ".github/workflows/build-onnxruntime-macos.yml"
- "scripts/fetch-onnxruntime.mjs"
Expand Down
22 changes: 21 additions & 1 deletion scripts/fetch-onnxruntime.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,32 @@ const PINNED = {
member: "onnxruntime.dll",
out: "onnxruntime.dll",
},
// The one target that does NOT come from upstream, and it is not a preference.
// Microsoft's `onnxruntime-osx-arm64-1.27.1.tgz` is built for macOS 14, this app
// declares a 13.0 floor, and `before-pack.cjs` refuses a payload demanding more —
// correctly, since the deployment target decides which symbols the linker resolves
// against the OS rather than emitting locally (#515). So `npm run build:mac` could
// not package at all. No published release fixes that: every one from 1.24 on is
// `minos 14.0`, and every one before it is at least 13.3.
//
// This one is built by `.github/workflows/build-onnxruntime-macos.yml` from the
// commit above, with the deployment target pinned, and published under a
// `v0.0.0-*` tag — the marker this repo already uses for a binary that needs a
// permanent URL but is not a product version. Its provenance is attested:
//
// gh attestation verify onnxruntime-osx-arm64-1.27.1.tgz --repo getopenscreen/openscreen
//
// Everything else about it is unchanged: immutable URL, SHA-256 verified before
// the archive is opened. What moved is who built the bytes, not how far they are
// trusted.
"darwin-arm64": {
slug: "osx-arm64",
ext: "tgz",
sha256: "e42b77a7281cc6e55141bf44fcfbac2c782b823a491bbb6ac33c781dd991f8a6",
sha256: "b8b7e62786eea42fc867bdbc2d3f573655a4b0e602c6938c4cea151a9ef71623",
member: `libonnxruntime.${VERSION}.dylib`,
out: "libonnxruntime.dylib",
baseUrl:
"https://github.com/getopenscreen/openscreen/releases/download/v0.0.0-onnxruntime-1.27.1",
},
// Linux is wired into `build:linux` since its back-end gained the capture half
// (`capture_webcam_rgb` + `set_webcam_mask` in `compositor_linux.rs`). Until
Expand Down
Loading