Conversation
Previously, these tests were conflating linebreaks and variable separators. This commit resolves that by changing diff comparison from raw strings to the hex content of those strings. Example failure with this change (note linebreak `\x0a` vs NUL char `\x00`): $ ./test/test-with-pgenvblock.sh [test-with-pgenvblock] Testing... [test-with-pgenvblock] Testing: specific postgres-related variables... 1,2c1,2 < 00000000: 5047 5353 4c4d 4f44 453d 320a 5047 4441 PGSSLMODE=2.PGDA < 00000010: 5441 4241 5345 3d34 0a TABASE=4. --- > 00000000: 5047 5353 4c4d 4f44 453d 3200 5047 4441 PGSSLMODE=2.PGDA > 00000010: 5441 4241 5345 3d34 00 TABASE=4. [test-with-pgenvblock] !!! [test-with-pgenvblock] !!! Test failed; see above for differences between '< actual' and '> expected' [test-with-pgenvblock] !!! Ref getodk#2203
alxndrsn
marked this pull request as ready for review
September 25, 2026 06:47
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, these tests were conflating linebreaks and variable separators. This commit resolves that by changing diff comparison from raw strings to the hex content of those strings.
Example failure with this change (note linebreak
\x0avs NUL char\x00):Ref #2203
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Accurate tests allow for accurate future implementation fixes.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
No risk.
Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.