Release v2026.4.0 - #2254
Draft
matthew-white wants to merge 5 commits into
Draft
Release v2026.4.0#2254matthew-white wants to merge 5 commits into
matthew-white wants to merge 5 commits into
Conversation
…2248) This seems to prevent a race condition related to volume creation order: Container central-postgres14-1 Error response from daemon: failed to mkdir /var/lib/docker/volumes/central_postgres14/_data/data: mkdir /var/lib/docker/volumes/central_postgres14/_data/data: file exists This error was seen ~3% of the time when running: * `postgres` container based on `tianon/postgres-upgrade:9.6-to-14` * `postgres14` container based on `pgautoupgrade/pgautoupgrade:17.11-trixie` Given the vague nature of both the error itself, and reproduction circumstances, it seems prudent to introduce this dependency. The dependency itself seems logical, as the `postgres14` container should be waiting for the `postgres` container to create a flag file before PostgreSQL itself starts up. See: * moby/moby#47021 * https://forums.docker.com/t/error-while-creating-mount-source-path-after-docker-desktop-update-to-v4-35/144676
In the original implementation (#343), old postgres data was cleaned up automatically if a specific flag file was present. This behaviour was changed (prior to release?) in a follow-up PR (#395) to link to documentation instead. Over time, it's become less clear which part of the linked documentation is relevant. This PR aims to link more directly to the relevant documentation.
For legacy reasons, some `npm` commands were being invoked in `./test/nginx` instead of `./test`. This works because `npm` looks for the nearest `package.json` file and uses its directory as PWD. But also quite confusing, especially in the case of `npm run test:service`, which has nothing to do with the code in `test/nginx`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the release of v2026.4. It should only contain changes from other PRs that have already been approved and merged (and possibly merge commits from the
masterbranch).