ci: fix npm/package.json location references - #2249
Merged
Merged
Conversation
For legacy reasons, some `npm` commands were being invoked in `./test/nginx` instead of `./test`. This works because `npm` looks for the nearest `package.json` file and uses its directory as PWD. But also quite confusing, especially in the case of `npm run test:service`, which has nothing to do with the code in `test/nginx`.
alxndrsn
marked this pull request as ready for review
September 15, 2026 12:40
lognaturel
approved these changes
Sep 15, 2026
matthew-white
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains work foundational to:
For legacy reasons, some
npmcommands were being invoked in./test/nginxinstead of./test. This works becausenpmlooks for the nearestpackage.jsonfile and uses its directory as PWD. But also quite confusing, especially in the case ofnpm run test:service, which has nothing to do with the code intest/nginx.What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Could be left as-is.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
No risk.
Is this change user-facing or otherwise noteworthy to users? If so, please add an entry for it in CHANGELOG.md.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.