Repository navigation
Google: index ids for the jsl.dh splice, reuse the soup for extras (~… - #28
Merged
Merged
Conversation
…40% faster parse) The AI-overview splice found each fragment's target with root.find(id=...), a walk of the whole tree per fragment and round: a third of a desktop parse. An id index built once gives the same element (first live one in document order; a repeated id still goes through find). parse_extras takes the soup parse already built instead of parsing the page again. Same output on all 29 fixtures; 3.67 s -> 2.24 s over the 12 largest.
Moves the Unreleased parse speed-up under 0.5.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…40% faster parse)
The AI-overview splice found each fragment's target with root.find(id=...), a walk of the whole tree per fragment and round: a third of a desktop parse. An id index built once gives the same element (first live one in document order; a repeated id still goes through find). parse_extras takes the soup parse already built instead of parsing the page again.
Same output on all 29 fixtures; 3.67 s -> 2.24 s over the 12 largest.
Description
Brief description of the changes.
Type of Change
Checklist
uv run pytest)uv run ruff check .)uv run mypy src/search_parser)Test Plan
How were these changes tested?