Repository navigation
fix: add chown and chmod helpers - #22
Draft
neurekadev wants to merge 1 commit into
Draft
neurekadev wants to merge 1 commit into
neurekadev wants to merge 1 commit into
Conversation
Arcane restores an uploaded volume archive into a newly created Compose volume by copying the archive root's owner and mode onto the volume root with chown and chmod. The image had neither applet, so project copy/move with volumes failed with "chown: not found". Refs getarcaneapp/arcane#4885 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
Author
🔍 Code ReviewPR #22 · 🤖 Claude Opus 5.5 (High) · T3 Code (Claude Code) · Round 1 of 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merge order: getarcaneapp/arcane#4887 first, then this. On its own, this would let Arcane's restore step run, but that step currently copies the wrong owner and mode (
root:root 0777). getarcaneapp/arcane#4887 makes it take them from the archive.Closes getarcaneapp/arcane#4885 together with getarcaneapp/arcane#4887.
What
Adds the BusyBox
chownandchmodapplets (CONFIG_CHOWN,CONFIG_CHMOD, plus their/binlinks) and lists them in the README.Why
When Arcane restores an uploaded volume archive into a newly created Compose volume (project copy/move with volumes, released in 3.1.0), it sets the volume root's owner and mode with
chown/chmodin this helper image. Neither applet was built in, so every such restore failed withsh: line 0: chown: not found.Testing
just build --platform linux/amd64andjust test ghcr.io/getarcaneapp/tools:dev: all validation checks passed, including "no extra helper commands slipped into the runtime image".chown: not found. The run is in fix: restore a new volume's root owner and mode from the archive arcane#4887's Evidence.AI disclosure
Claude Code (Claude Opus 5.5) investigated this, made the change and drafted this description, at my direction.
🤖 Generated with Claude Code