Repository navigation
Conversation
- Remove the translucent background and z-index from the sticky header on the container new and edit pages - Add bottom margin to the header and fill the page height with the wrapper - Drop the redundant full-width class on the header content row
| <div class="flex min-h-0 flex-col"> | ||
| <div class="sticky top-0 z-10 border-b bg-background/95"> | ||
| <div class="mx-auto flex h-16 w-full max-w-full items-center gap-4 px-6"> | ||
| <div class="flex h-full min-h-0 flex-col"> |
Contributor
There was a problem hiding this comment.
Header scrolls away on long forms. On desktop,
h-full limits this wrapper to the height of the app’s visible content area, but ContainerForm still grows beyond it. With enough environment variables or other rows, scrolling reaches the wrapper’s bottom and pushes the sticky header away while the form continues. The edit page has the same change.
Keep the wrapper tall enough for the form, or give the form its own scroll area like the stack editor does.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/routes/(app)/containers/new/+page.svelte
Line: 52
Comment:
**Header scrolls away on long forms.** On desktop, `h-full` limits this wrapper to the height of the app’s visible content area, but `ContainerForm` still grows beyond it. With enough environment variables or other rows, scrolling reaches the wrapper’s bottom and pushes the sticky header away while the form continues. The edit page has the same change.
Keep the wrapper tall enough for the form, or give the form its own scroll area like the stack editor does.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranchm.*())What This PR Implements
The Create Container and Edit Container pages rendered their sticky header in a dark, inset band. It did not match the create pages for Swarm stacks, Quadlets, and Projects. The header sat in a
bg-background/95box withz-10, and the row usedw-full.This PR changes both container pages to the same header structure those pages use:
sticky top-0 mb-2 border-b, with noz-10orbg-background/95.h-full.w-fullremoved.Fixes: N/A (no linked issue)
Changes Made
frontend/src/routes/(app)/containers/new/+page.svelte: header and wrapper classes aligned with the other create pages.frontend/src/routes/(app)/containers/[containerId]/edit/+page.svelte: same header change, so create and edit match.No logic, routes, or strings changed.
Testing Done
just format frontend: passed, no changes.just lint frontend: passed./swarm/stacks/newis still to be confirmed.AI Tool Used (if applicable)
Additional Context
The frontend lint run needed Paraglide messages generated in this worktree. They were generated into
frontend/src/lib/paraglide, which git ignores, so they are not part of this diff.Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.The PR appears safe to merge, with a non-blocking scrolling issue on long forms.
Fix with agent prompt
Summary
The PR aligns the Create Container and Edit Container headers with other create pages.
One scrolling issue remains: long forms can outgrow the wrapper and lose their sticky header. Browser checks were not run.
Reviews (1) · Last reviewed commit: "fix: align container create and edit pag..." · Reviewed by Greptile