Skip to content

fix: align container create and edit page headers - #4892

Open
kmendell wants to merge 1 commit into
mainfrom
fix/create-container-header
Open

kmendell wants to merge 1 commit into
mainfrom
fix/create-container-header

Conversation

@kmendell

@kmendell kmendell commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Checklist

  • This PR is not opened from my fork's main branch
  • All new user-facing strings are translated via Paraglide (m.*())

What This PR Implements

The Create Container and Edit Container pages rendered their sticky header in a dark, inset band. It did not match the create pages for Swarm stacks, Quadlets, and Projects. The header sat in a bg-background/95 box with z-10, and the row used w-full.

This PR changes both container pages to the same header structure those pages use:

  • Header: sticky top-0 mb-2 border-b, with no z-10 or bg-background/95.
  • Outer wrapper: h-full.
  • Inner row: w-full removed.

Fixes: N/A (no linked issue)

Changes Made

  • frontend/src/routes/(app)/containers/new/+page.svelte: header and wrapper classes aligned with the other create pages.
  • frontend/src/routes/(app)/containers/[containerId]/edit/+page.svelte: same header change, so create and edit match.

No logic, routes, or strings changed.

Testing Done

  • just format frontend: passed, no changes.
  • just lint frontend: passed.
  • Not checked in a browser. Visual result against /swarm/stacks/new is still to be confirmed.

AI Tool Used (if applicable)

Additional Context

The frontend lint run needed Paraglide messages generated in this worktree. They were generated into frontend/src/lib/paraglide, which git ignores, so they are not part of this diff.

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking scrolling issue on long forms.

Fix All in CodexFindings

  1. P2 Header scrolls away on long forms ▶
Fix with agent prompt
### Issue 1
frontend/src/routes/(app)/containers/new/+page.svelte:52
**Header scrolls away on long forms.** On desktop, `h-full` limits this wrapper to the height of the app’s visible content area, but `ContainerForm` still grows beyond it. With enough environment variables or other rows, scrolling reaches the wrapper’s bottom and pushes the sticky header away while the form continues. The edit page has the same change.

Keep the wrapper tall enough for the form, or give the form its own scroll area like the stack editor does.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR aligns the Create Container and Edit Container headers with other create pages.

  • Container creation and editing now use matching sticky headers.

One scrolling issue remains: long forms can outgrow the wrapper and lose their sticky header. Browser checks were not run.

Reviews (1) · Last reviewed commit: "fix: align container create and edit pag..." · Reviewed by Greptile

- Remove the translucent background and z-index from the sticky header on the container new and edit pages
- Add bottom margin to the header and fill the page height with the wrapper
- Drop the redundant full-width class on the header content row
@kmendell
kmendell requested a review from a team November 19, 2026 00:09
<div class="flex min-h-0 flex-col">
<div class="sticky top-0 z-10 border-b bg-background/95">
<div class="mx-auto flex h-16 w-full max-w-full items-center gap-4 px-6">
<div class="flex h-full min-h-0 flex-col">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Header scrolls away on long forms. On desktop, h-full limits this wrapper to the height of the app’s visible content area, but ContainerForm still grows beyond it. With enough environment variables or other rows, scrolling reaches the wrapper’s bottom and pushes the sticky header away while the form continues. The edit page has the same change.

Keep the wrapper tall enough for the form, or give the form its own scroll area like the stack editor does.

Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/routes/(app)/containers/new/+page.svelte
Line: 52

Comment:
**Header scrolls away on long forms.** On desktop, `h-full` limits this wrapper to the height of the app’s visible content area, but `ContainerForm` still grows beyond it. With enough environment variables or other rows, scrolling reaches the wrapper’s bottom and pushes the sticky header away while the form continues. The edit page has the same change.

Keep the wrapper tall enough for the form, or give the form its own scroll area like the stack editor does.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex Fix in Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant