Skip to content

fix: align table row action button and hover corners - #4882

Merged
kmendell merged 1 commit into
mainfrom
fix/table-hover-corners-action-button
Nov 18, 2026
Merged

kmendell merged 1 commit into
mainfrom
fix/table-hover-corners-action-button

Conversation

@kmendell

@kmendell kmendell commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Checklist

  • This PR is not opened from my fork's main branch
  • All new user-facing strings are translated via Paraglide (m.*())

What This PR Implements

Fixes two visual issues in the table row hover state. Both apply to every table that uses the row actions menu.

  • The hover highlight rounded only the left corners. The right corners stayed square.
  • The row … trigger was 32px, and the floating pill's shadow-lg made it look like a raised blob.

Fixes: no issue linked

Changes Made

  • frontend/src/lib/components/ui/table/table-cell.svelte
    • The actions column is a zero-width pinned cell, so last:rounded-r-lg landed on an empty cell. Added [&:has(+[data-pinned]:last-child)]:rounded-r-lg so the cell before a pinned trailing cell gets the right-side rounding.
    • Floating actions pill shadow: shadow-lg → shadow-sm.
  • frontend/src/lib/components/arcane-table/row-actions-menu.svelte
    • Default triggerClass: size-8 → size-7 (32px → 28px).

Impact: the new default trigger size and pill shadow apply to all 37 table files that use RowActionsMenu. None of them override triggerClass.

Testing Done

  • just format all: passed.
  • just lint all: failed in the frontend step. This worktree has no generated frontend/src/lib/paraglide, so the check reports 525 errors of Cannot find module '#lib/paraglide/messages.js'. None are in the changed files. The frontend step failed first, so the lint steps after it did not run. Lint is not verified.
  • Not checked in a browser. Needs a visual check: hover a row on a table with an actions column, such as the containers page, and confirm both ends of the highlight are rounded and the trigger is smaller.

AI Tool Used (if applicable)

Additional Context

  • Tables without a pinned trailing cell keep the existing last:rounded-r-lg behavior.

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

This PR rounds the visible right edge of table rows with pinned actions, shrinks the default menu button, and softens the floating pill’s shadow.

  • Rows with pinned actions now have a rounded right edge.
  • Row action menus use a smaller button and a softer pill shadow.

Reviews (1) · Last reviewed commit: "fix: align table row action button and h..." · Reviewed by Greptile

- Shrink the row actions trigger from size-8 to size-7
- Round the right edge of the cell before a pinned actions cell so the hover corners match
- Reduce the pinned actions popover shadow from shadow-lg to shadow-sm
@kmendell
kmendell requested a review from a team November 18, 2026 22:02
@kmendell
kmendell merged commit e8e5b23 into main Nov 18, 2026
21 checks passed
@kmendell
kmendell deleted the fix/table-hover-corners-action-button branch November 18, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant