Repository navigation
fix: align table row action button and hover corners - #4882
Merged
Merged
Conversation
- Shrink the row actions trigger from size-8 to size-7 - Round the right edge of the cell before a pinned actions cell so the hover corners match - Reduce the pinned actions popover shadow from shadow-lg to shadow-sm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranchm.*())What This PR Implements
Fixes two visual issues in the table row hover state. Both apply to every table that uses the row actions menu.
…trigger was 32px, and the floating pill'sshadow-lgmade it look like a raised blob.Fixes: no issue linked
Changes Made
frontend/src/lib/components/ui/table/table-cell.sveltelast:rounded-r-lglanded on an empty cell. Added[&:has(+[data-pinned]:last-child)]:rounded-r-lgso the cell before a pinned trailing cell gets the right-side rounding.shadow-lg→shadow-sm.frontend/src/lib/components/arcane-table/row-actions-menu.sveltetriggerClass:size-8→size-7(32px → 28px).Impact: the new default trigger size and pill shadow apply to all 37 table files that use
RowActionsMenu. None of them overridetriggerClass.Testing Done
just format all: passed.just lint all: failed in the frontend step. This worktree has no generatedfrontend/src/lib/paraglide, so the check reports 525 errors ofCannot find module '#lib/paraglide/messages.js'. None are in the changed files. The frontend step failed first, so the lint steps after it did not run. Lint is not verified.AI Tool Used (if applicable)
Additional Context
last:rounded-r-lgbehavior.Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR rounds the visible right edge of table rows with pinned actions, shrinks the default menu button, and softens the floating pill’s shadow.
Reviews (1) · Last reviewed commit: "fix: align table row action button and h..." · Reviewed by Greptile