Publish techdocs via OIDC instead of static AWS credentials - #125
Merged
Merged
Conversation
The techdocs workflow no longer passes TRUSS_AWS_ACCESS_KEY_ID / TRUSS_AWS_SECRET_ACCESS_KEY to the Bridge Backstage Techdocs action. The action now assumes the github-truss IAM role via GitHub OIDC by default, so the workflow only needs to grant id-token: write. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesh-gomo
previously approved these changes
Aug 17, 2026
jamesh-gomo
left a comment
jamesh-gomo
left a comment
Member
There was a problem hiding this comment.
Hi @psi ,
The change looks good. I don't think we can't really test this until it's merged into Master - so keeping an eye on Spinnaker staging and edge env's after merging is probably the safest way to confirm it's working
- Fix RuboCop Style/HashAsLastArrayItem offenses in destinations.rb and dispatches.rb by wrapping implicit hashes in explicit braces - Widen bundler dev dependency from ~> 2.0 to >= 2.0 so Ruby head (which ships Bundler 4.x) can resolve dependencies - Remove deprecated macos-13 runner from CI matrix Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates this repo's techdocs publishing off the static
TRUSS_AWS_ACCESS_KEY_ID/TRUSS_AWS_SECRET_ACCESS_KEYorg secrets and onto GitHub OIDC role assumption.The shared Bridge Backstage Techdocs action (
get-bridge/developer_portal/.github/actions/techdocs) now assumes thegithub-trussIAM role via OIDC by default (see get-bridge/developer_portal#105). Consumers only need to:permissions: id-token: writeon the job.aws_access_key_id/aws_secret_access_keyinputs.No AWS credentials are handled by this workflow anymore.
This depends on get-bridge/developer_portal#105 being merged first. This workflow tracks the action at
ref: master, and until #105 lands the action still marks those credential inputs as required. Please merge #105 before merging this PR.Reference migration pattern: get-bridge/bridge-instilled@a3545c8.
CI build fixes
This PR also fixes pre-existing CI failures unrelated to the OIDC change:
Style/HashAsLastArrayItem— Wrapped implicit hashes inside array literals with explicit{}braces indestinations.rbanddispatches.rb. RuboCop 1.89.0 (installed in CI) flags the implicit form.headbundler compatibility — Widened the bundler dev dependency from~> 2.0to>= 2.0. Ruby head ships Bundler 4.x, which the pessimistic constraint rejected.macos-13runner — GitHub deprecated macOS-13 runners; jobs hung for 24 hours before being cancelled. The workflow still tests onmacos-latestandmacos-latest-large.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com