Repository navigation
Conversation
Author
|
Regenerated from the reworked upstream PR (gnustep/libs-back#249): the mechanism note is corrected, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the
-screenListsingle-monitor fix as a patch layer, per thelanding agreement in gershwin-desktop/issues#95: the root cause lives in
gnustep/libs-back (upstream PR linked in the .PR.md), Gershwin images get
the fix now, and the patch is dropped once upstream merges.
The diff normalizes the single connected monitor's frame from the root
geometry after the RANDR loop when no work area is published, guarded by
workAreas == nilso a window manager's_NET_WORKAREAstill wins. Themechanism note is regenerated from the reworked upstream branch: an
fb-only resize (
xrandr --fb, streaming servers) does not touch theCRTC, which keeps accurately reporting the mode it still drives inside
the grown framebuffer; with no work area published, the root geometry is
the only authority left for the screen. Without it the desktop window
clamps against a screen that no longer exists (origin.x = -400 after
1280x800 -> 1680x1050 at GSScaleFactor 2.0).
Validated with the pixel-assertion resize harness (Xvfb + RANDR, 13
points per screenshot): 13/13 on baseline and after both resize hops,
three consecutive runs, on top of gnustep/libs-back master @ 41c46c5;
upstream the fix also carries a self-contained test
(
Tests/x11/screenframe.m) with CI green on all five backends. The patchcarries the source change only and is verified to apply on the current
libs-back pin (bbcc3de) on top of
screen-work-area-api.cc @probonopd