Skip to content

Add libs-back screenlist-root-geometry patch (single-monitor screen frame) - #76

Open
e4779 wants to merge 2 commits into
gershwin-desktop:devfrom
e4779:libs-back-screenlist-patch
Open

e4779 wants to merge 2 commits into
gershwin-desktop:devfrom
e4779:libs-back-screenlist-patch

Conversation

@e4779

@e4779 e4779 commented Oct 12, 2026 •

Copy link
Copy Markdown

Carries the -screenList single-monitor fix as a patch layer, per the
landing agreement in gershwin-desktop/issues#95: the root cause lives in
gnustep/libs-back (upstream PR linked in the .PR.md), Gershwin images get
the fix now, and the patch is dropped once upstream merges.

The diff normalizes the single connected monitor's frame from the root
geometry after the RANDR loop when no work area is published, guarded by
workAreas == nil so a window manager's _NET_WORKAREA still wins. The
mechanism note is regenerated from the reworked upstream branch: an
fb-only resize (xrandr --fb, streaming servers) does not touch the
CRTC, which keeps accurately reporting the mode it still drives inside
the grown framebuffer; with no work area published, the root geometry is
the only authority left for the screen. Without it the desktop window
clamps against a screen that no longer exists (origin.x = -400 after
1280x800 -> 1680x1050 at GSScaleFactor 2.0).

Validated with the pixel-assertion resize harness (Xvfb + RANDR, 13
points per screenshot): 13/13 on baseline and after both resize hops,
three consecutive runs, on top of gnustep/libs-back master @ 41c46c5;
upstream the fix also carries a self-contained test
(Tests/x11/screenframe.m) with CI green on all five backends. The patch
carries the source change only and is verified to apply on the current
libs-back pin (bbcc3de) on top of screen-work-area-api.

cc @probonopd

@e4779

e4779 commented Oct 27, 2026

Copy link
Copy Markdown
Author

Regenerated from the reworked upstream PR (gnustep/libs-back#249): the mechanism note is corrected, the workAreas == nil guard from the upstream discussion is included, and the patch is verified to apply on the current libs-back pin (bbcc3de) on top of screen-work-area-api. The test lives in the upstream PR; the patch carries the source change only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant