Improve search result page titles#264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seofallback and the React Routermetaexport so browser titles and SSR metadata stay aligned.f[...]andbbox=URL shapes as well as currentinclude_filters[...]geo/facet params.Impact
Facet-only and bounding-box search pages now produce distinct page titles such as
Place: Wisconsin / Resource Class: Maps / Resource Type: Topographic mapsandBounding Box: -87.1418 28.265814 -50.799027 60.34877, which should make Google Analytics page-title reporting easier to segment.Validation
npm test -- searchPageTitle page-titles./node_modules/.bin/prettier --check src/utils/searchPageTitle.ts src/__tests__/utils/searchPageTitle.test.ts src/pages/SearchPage.tsx src/__tests__/pages/page-titles.test.tsx app/routes/search.tsx./node_modules/.bin/eslint src/utils/searchPageTitle.ts src/pages/SearchPage.tsx src/__tests__/utils/searchPageTitle.test.ts src/__tests__/pages/page-titles.test.tsx app/routes/search.tsx(0 errors; existing route Fast Refresh warnings remain)git diff --checkNote: full
npm run lintstill reports existing unrelated lint errors across other frontend files.