Add Allmaps map overlay search facet#263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
Map Overlaysearch facet so users can filter search results down to Allmaps-annotated maps from the main results page.What changed
b1g_georeferenced_allmaps_bfromresource_allmaps.annotatedfor Elasticsearch documents.map_overlay_agg.Map Overlayfacet label/order and boolean value handling fortrue/falsebuckets.Notes
Existing deployments will need a reindex before the facet counts appear, since the field is populated at index time.
Refs #72.
Validation
/Users/ewlarson/.pyenv/versions/3.13.1/bin/python -m pytest backend/tests/elasticsearch/test_index.py backend/tests/elasticsearch/test_facet_functions.py backend/tests/elasticsearch/test_mappings.py backend/tests/services/test_search_service.py backend/tests/api/v1/test_strong_params.py backend/tests/api/v1/test_facet_endpoint.pynpm test -- --run src/__tests__/utils/facetLabels.test.ts src/__tests__/utils/facetDisplay.test.ts src/__tests__/utils/searchParams.test.ts src/__tests__/components/FacetList.test.tsx./node_modules/.bin/eslint src/constants/facets.ts src/constants/fieldLabels.ts src/services/api.ts src/utils/facetDisplay.ts src/utils/facetLabels.ts src/utils/searchParams.ts src/__tests__/utils/facetLabels.test.ts src/__tests__/utils/facetDisplay.test.ts src/__tests__/utils/searchParams.test.ts src/__tests__/components/FacetList.test.tsx/Users/ewlarson/.pyenv/versions/3.13.1/bin/python -m ruff check backend/app/api/v1/strong_params.py backend/app/elasticsearch/index.py backend/app/elasticsearch/mappings.py backend/app/elasticsearch/search.py backend/app/services/search_service.py backend/scripts/reindex_atomic.py backend/tests/api/v1/test_facet_endpoint.py backend/tests/api/v1/test_strong_params.py backend/tests/elasticsearch/test_facet_functions.py backend/tests/elasticsearch/test_mappings.py backend/tests/elasticsearch/test_index.py backend/tests/services/test_search_service.pynpm run build