Repository navigation
Release: compare an edited git-sourced plugin with composer.lock's ref - #5
Merged
Merged
Conversation
The release check hashes the checkout's composer install. A foreman worktree clones that install from the main checkout, and Composer doesn't reinstall a version it already has, so hand edits there became the baseline: holmasto's urgent flag on three Conditional Shipping and Payments files was production being clean and the local copy edited. A differing file in an unpatched plugin or mu-plugin installed from GitHub (composer.lock source type git) is now fetched at the lock's ref with gh; when production matches it, it isn't flagged and a note names the edited checkout. A fetch that fails keeps the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release check hashes the checkout's composer install. A foreman worktree clones that install from the main checkout, and Composer doesn't reinstall a version it already has, so hand edits in the main checkout became the baseline.
holmasto's urgent
release:web/app/plugins/woocommerce-conditional-shipping-and-paymentsflag was exactly that: all 67 PHP files on production match the fork at the lock's reffc60653, while the local copy had three hand-addedpublic $method_title;declarations.ReadReporecordsSources: unpatched plugins and mu-plugins whose lock source is git on github.com, by install folder, with the lock's ref.release()fetches a differing file of one of those at the ref (gh api …/contents/…?ref=, read only). When production matches, it isn't flagged; a note names the edited checkout. A failed fetch keeps the flag.Checked against GitHub: the fetched
class-wc-csp-restrict-shipping-methods.phpatfc60653is byte-identical to production's.go vet ./...andgo test ./...pass.Foreman still pins wp-data-audit at
0144758, so it needs a bump to pick this (and #2–#4) up.🤖 Generated with Claude Code