Skip to content

Report real visitors' rejections to gds-monitoring - #10

Merged
oxyc merged 1 commit into
mainfrom
feat/report-to-monitoring
Nov 18, 2026
Merged

oxyc merged 1 commit into
mainfrom
feat/report-to-monitoring

Conversation

@oxyc

@oxyc oxyc commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Moves the ALTCHA rejection alert out of gds-monitoring and into this plugin, using gds-monitoring's new gds/monitoring/report hook (generoi/gds-monitoring#6).

  • An expired or invalid_signature rejection is reported, every one (no throttle): both take a real, signed challenge, so they point to a person turned away, and nothing is saved for a refused submission.
  • Missing, malformed and replayed proofs (what bots send) aren't reported.
  • Same message as before: report altcha blog 2: rejected form 4 (expired): 125 s past expiry.
  • A plain do_action, so nothing happens without gds-monitoring.

Tests: 2 new mocked tests (a missing proof isn't reported; a proof signed with another key is). All 69 tests and Pint pass.

Release and roll out this before (or with) gds-monitoring #6, which drops its own AltchaRejections check: a site on the new gds-monitoring with an older altcha logs no ALTCHA rejections. The other way round is safe; the old check keeps logging and the hook call goes nowhere.

🤖 Generated with Claude Code

Expired and invalid-signature rejections take a real, signed challenge, so
they point to a person turned away, and nothing is saved for a refused
submission. Report each one through gds/monitoring/report (a no-op without
gds-monitoring), replacing gds-monitoring's own AltchaRejections check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oxyc added a commit to generoi/gds-monitoring that referenced this pull request Nov 18, 2026
gravityforms-altcha now reports its own rejections through
gds/monitoring/report (generoi/gravityforms-altcha#10), with the same line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oxyc
oxyc merged commit fb728da into main Nov 18, 2026
5 checks passed
oxyc added a commit to generoi/gds-monitoring that referenced this pull request Nov 18, 2026
…ne path (#6)

* feat: PlmSync check for wp-plm's beCPG import

Logs wp-plm's errors and warnings (first per 12 h) and, hourly, a type whose full sync last completed over 26 h ago, read from the plm_last_completed option wp-plm now records. Sites without a completed sync are never reported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat: generic report and job hooks for other plugins, replacing PlmSync

Plugins call gds/monitoring/report (logged, first per source in 12 h) and gds/monitoring/completed with a max age (Jobs reports it hourly once overdue), so monitoring needs no knowledge of each plugin. wp-plm uses both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor: route every check through the report hook

All built-in checks now write through Reports::write(), the same path
plugins use via gds/monitoring/report, so every line has one shape:
report <source> blog <id>: <message>. Throttling and masking live in
one place.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor: move the ALTCHA rejection check into gravityforms-altcha

gravityforms-altcha now reports its own rejections through
gds/monitoring/report (generoi/gravityforms-altcha#10), with the same line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant