Repository navigation
fix: only register genero-woocommerce's views path when it exists - #500
Merged
Merged
Conversation
acorn optimize's view:cache throws on a registered path that doesn't exist, which failed the deploy after the symlink. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp acorn optimizerunsview:cache, which walks every registered view path. genero-woocommerce registersresources/views, a folder this copy of the plugin doesn't have, soview:cachethrowsDirectoryNotFoundExceptionand fails the deploy after the symlink. That left the object-cache flush, OPcache reset and Kinsta purge unrun on widetoes and medihealth today.The old deploy step only cleared Acorn's caches (
cache:clear:wp:acorn), so this never surfaced. The new purge order regenerates them (cache:wp:acorn).Change
Register the
genero-woocommerceview namespace only whenresources/viewsexists.Testing
php -lpasses. After deploy, the deploy log'scache:wp:acornshowsviews … DONE.🤖 Generated with Claude Code