Own current wallet state in a single session service - #834
Merged
Conversation
WalletService re-published six members of WalletSessionService verbatim, and both were registered side by side in the SwiftUI environment, so the same state had two access paths and three setter shapes. Delete the forwarders and move setCurrent(wallet:) onto WalletSessionManageable, keeping its MainActor hop. WalletService is now lifecycle only: create, import, delete, pin, rename, setup, export. Consumers that only need the current wallet take the protocol instead of the concrete service, so NFT, Transfer, Transactions and WalletTab no longer depend on WalletService and its transitive Keystore edge. InAppNotificationService kept a walletService it never read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current wallet had two owners:
WalletServicere-published six members ofWalletSessionServiceword for word, and both sat in the SwiftUI environment at once, so screens picked whichever one they happened to know about.Now
WalletSessionServiceowns the current wallet, andWalletServiceonly handles the wallet lifecycle. Screens that just need to know which wallet is selected no longer receive a service that can also export a secret phrase.No behaviour change.