Fix broken set_notice_(receiver|processor) callback after GC.compact - #735
Merged
Conversation
The `VALUE` object passed to libpq was not updated at `GC.compact` . Instead we better pass the xmalloc'ed TDATA pointer to libpq and add the `self` object to the struct as a back reference. That `self` object is relocated at GC.compact . Also add a test case which triggers and verifies the relocation. Fixes ged#734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VALUEobject passed to libpq was not updated atGC.compact. Instead we better pass the xmalloc'ed TDATA pointer to libpq and add theselfobject to the struct as a back reference. Thatselfobject is relocated at GC.compact .Also add a test case which triggers and verifies the relocation.
Fixes #734