Skip to content

[numericalsgps] Update to 1.5.0 - #1549

Merged
fingolfin merged 1 commit into
mainfrom
automatic/numericalsgps
Sep 30, 2026
Merged

[numericalsgps] Update to 1.5.0#1549
fingolfin merged 1 commit into
mainfrom
automatic/numericalsgps

Conversation

@gap-package-distribution-bot

@gap-package-distribution-bot gap-package-distribution-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Auto-merge

This pull request may be auto-merged after all required checks pass.
To prevent this pull request from being auto-merged, leave a comment.
To comment without blocking auto-merge, include [noblock] in the comment.

@gap-package-distribution-bot gap-package-distribution-bot Bot added automated pr Automatically applied to PRs created by a GH workflow package update labels Sep 4, 2026
@gap-package-distribution-bot

gap-package-distribution-bot Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Package Evaluation Report for GAP master

Job Properties

Testing: master/2026/09/30_16-11-21 vs master/2026/09/30_15-22-56

Distribution revision: f7e2ba49

Generated by Workflow: https://github.com/gap-system/PackageDistro/actions/runs/36736530631

In total, 173 packages were tested, out of which 170 succeeded, 0 failed and 3 were skipped.

✔️ ✔️ Packages now succeeding

1 package(s) succeeded tests only on the current version.

✔️ Packages still succeeding

169 package(s) succeeded tests also on the previous version.

Click to show packages!

➖ Packages that were skipped

3 package(s) skipped tests also on the previous version.

Click to show packages!

@fingolfin

fingolfin commented Sep 8, 2026

Copy link
Copy Markdown
Member

@ManuelAFDelgado @pedritomelenas unfortunately this release can't be merged into the packagedistro: it fails LoadAllPackages(); see the logs; here's the salient bit:

#I  NumericalSgps: entering LoadPackage 
#I  NumericalSgps: return from LoadPackage, package was already loaded
#I  OpenMath: entering LoadPackage 
#I  OpenMath: PackageAvailabilityInfo for version 11.5.5
#I  OpenMath: PackageAvailabilityInfo: the AvailabilityTest function returned 'true'
#I  OpenMath: PackageAvailabilityInfo: check needed packages
#I            GAPDoc (>= 1.6.0)
#I            IO (>= 4.5.1)
#I  OpenMath: PackageAvailabilityInfo: check of needed packages done
#I  OpenMath: PackageAvailabilityInfo: version 11.5.5 is available
#I  OpenMath: start loading needed/suggested/self packages
#I            openmath
#I  OpenMath: start reading file 'init.g'
Error, Variable: 'HasseDiagram' is read only

So perhaps you added HasseDiagram but some other package also defines it?

@pedritomelenas

pedritomelenas commented Sep 8, 2026

Copy link
Copy Markdown

The thing is that our HasseDiagram is an operation, while that in OpenMath is not even documented and it is a function that takes a relation that is a binary relations that is a partial order. This is why probably I did not spot it while taking the name.
This has happened before (IsSymmetric ...). We can of course rename ours to ' HasseDiagramOfPosetNS' or some other name, or we could have HasseDiagram in OpenMath to be an operation. I have seen that @olexandr-konovalov and you are the ones doing the last commits in OpenMath. So, @olexandr-konovalov, what do you think?

@fingolfin

fingolfin commented Sep 10, 2026

Copy link
Copy Markdown
Member

Just had a look at the openmath package, and indeed: the manual does not mention the word "Hasse" at all.

The code is loaded by init.g, which says:

#################################################################
## Module 2.2
## This module is concerned with viewing Hasse diagrams;
## requires the variables defined in gap/omput.gd

ReadPackage("openmath", "/hasse/config.g");
ReadPackage("openmath", "/hasse/hasse.g");

... but why is this a "module" of the package if it is not mentioned anywhere in the documentation? Hmm.

The offending function then:

HasseDiagram := function(rel)
	local h;
	h :=  HasseDiagramBinaryRelation(rel);
	SetIsHasseDiagram(h,true);
	return h;
end;

So that's trivial, it just delegates to HasseDiagramBinaryRelation and then sets a filter. And this is just called in one place, in a test file! (The real workhorse is the function CreateHasseDiagram which is also not documented but at least called in multiple places and has a non-trivial implementation).

So I've now made gap-packages/openmath#30 to remove it from openmath. That seems like the easiest and quickest fix.

If numericalsgps makes HasseDiagram an operation then future extensions are always possible.

@olexandr-konovalov OK?

@gap-package-distribution-bot
gap-package-distribution-bot Bot force-pushed the automatic/numericalsgps branch 2 times, most recently from 61878d3 to 9e3a9d0 Compare September 10, 2026 14:36
@fingolfin fingolfin added the skip tests No CI tests are run for PRs with this label. Otherwise they run each time the distro is updated label Sep 11, 2026
@gap-package-distribution-bot
gap-package-distribution-bot Bot force-pushed the automatic/numericalsgps branch 3 times, most recently from ae16397 to a11468e Compare September 15, 2026 20:21
@gap-package-distribution-bot
gap-package-distribution-bot Bot force-pushed the automatic/numericalsgps branch 4 times, most recently from 095d3fc to 3255418 Compare September 25, 2026 11:20
@gap-package-distribution-bot
gap-package-distribution-bot Bot force-pushed the automatic/numericalsgps branch 5 times, most recently from 9d53d8c to 6d514a2 Compare September 29, 2026 13:28
@fingolfin fingolfin removed the skip tests No CI tests are run for PRs with this label. Otherwise they run each time the distro is updated label Sep 29, 2026
@fingolfin

fingolfin commented Sep 30, 2026

Copy link
Copy Markdown
Member

I've released a new openmath and now this PR passes.

@fingolfin
fingolfin merged commit d4744ea into main Sep 30, 2026
175 checks passed
@fingolfin
fingolfin deleted the automatic/numericalsgps branch September 30, 2026 21:54
@olexandr-konovalov

olexandr-konovalov commented Oct 10, 2026

Copy link
Copy Markdown
Member

@fingolfin ok )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated pr Automatically applied to PRs created by a GH workflow package update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fingolfin @pedritomelenas @olexandr-konovalov