Skip to content

fix: handle key error in translate_to - #639

Merged
korikuzma merged 1 commit into
mainfrom
issue-638
Jun 8, 2026
Merged

korikuzma merged 1 commit into
mainfrom
issue-638

Conversation

@korikuzma

Copy link
Copy Markdown
Contributor

close #638

  • Unsupported fmt in translate_to should raise NotImplementedError

close #638

* Unsupported `fmt` in `translate_to` should raise `NotImplementedError`
@korikuzma korikuzma self-assigned this Jun 8, 2026
@korikuzma korikuzma added the bug Something isn't working label Jun 8, 2026
@korikuzma
korikuzma requested review from a team as code owners June 8, 2026 17:39
@korikuzma korikuzma added the priority:low Low priority label Jun 8, 2026
@korikuzma
korikuzma merged commit a9a4897 into main Jun 8, 2026
16 checks passed
@korikuzma
korikuzma deleted the issue-638 branch June 8, 2026 18:12
korikuzma added a commit that referenced this pull request Jun 9, 2026
close #638

* Unsupported `fmt` in `translate_to` should raise `NotImplementedError`
theferrit32 added a commit to theferrit32/vrs-python that referenced this pull request Oct 28, 2026
Forward-merge main into vrs/2.1 so it is no longer behind. Net change to
vrs/2.1 is ga4gh#642 (is_intronic r. fix); the other main commits since the merge
base (ga4gh#635, ga4gh#639, ga4gh#645, ga4gh#648) were already ported as parallel PRs.

Conflict resolution:
- src/ga4gh/core/models.py: conflict between ga4gh#645 (main) and vrs/2.1's
  restructured models (ga4gh#644 + gkm-core updates). Took vrs/2.1's version, which
  already includes the int Extension.value fix.
- src/ga4gh/core/__init__.py: auto-merged without conflict but incorrectly,
  duplicating main's __version__ block (undefined `version`) and
  CORE_VERSION = "1.0.0" from ga4gh#648. Took vrs/2.1's version (CORE_VERSION from
  ga4gh.core.version, 1.3.0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority:low Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle key errors in translate_to

2 participants