This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
fix(ci): filter emSign trust paths before npm publishing - #1
Closed
skyfriends wants to merge 1 commit into
Closed
skyfriends wants to merge 1 commit into
skyfriends wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publishing workflow runs Node 12 with an older bundled trust store. Both jobs now remove the affected emSign and AAA trust paths before checkout, runtime setup, or npm publishing, and Node uses the filtered Ubuntu bundle. The guard rejects an affected or empty bundle. Checkout/setup-node move from retired v1 action runtimes to supported v4 actions; the application Node 12 selection remains unchanged.
Validation: actionlint passed. Official Node 12.22.12 with the filtered CA bundle rejected all 12 disclosed chains and succeeded for three healthy HTTPS controls. Positive/negative bundle guard checks and git diff --check passed. The workflow and npm publishing were not executed.
This is a temporary trust-root mitigation pending a compatible Node release containing the upstream intermediate-key blocklist. Certificates whose only trust path uses the removed roots are also rejected. Explicit application CA overrides and already-running processes require separate verification.
Reference: nodejs/node#66871
Desktop/manual application testing was not performed.