Repository navigation
feat(skills): rename writing-plans to future-writing-plans and enforce acceptance-criteria review gates - #124
Merged
futuregerald merged 1 commit intoNov 15, 2026
Conversation
…e acceptance-criteria review gates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writing-plans→future-writing-plans(/future-writing-plans):internal/catalog/shared/skills/writing-plansandinternal/catalog/antigravity/skills/writing-planstofuture-writing-plans.author: Jesse Vincent, Gerald Onyangoin YAML frontmatter,LICENSE.txt(MIT), and fork attribution footer crediting Jesse Vincent (obra/superpowers) and Gerald Onyango.internal/catalog/tracks.yaml,internal/catalog/catalog.go,scripts/sync-antigravity-from-local.sh, CLI/TUI tests, READMEs, harness templates (CLAUDE*,GEMINI*,AGENTS*), and all cross-referencing skills.future-writing-plans(Phase 3): Requires aProduct & Design Sourcessection and a mandatory## Acceptance Criteria & Success Metrics (Required Gate)table mapping every Phase Goal, Point-of-View Brief rule (docs/point-of-view/*.md), PRD/Decision (docs/prd.md,docs/decisions/*.md), and Approved UI Design (design-demos/*/direction-approved.md) to a measurable target and a mounted/wired runtime entry point (file:Symbol).Plan): Enforces presenting the proposed plan and Acceptance Criteria in chat and stopping for user confirmation before Phase 4 implementation unless the user explicitly says "just work", "work autonomously", "keep going", or invokes/goal.plan-review/adversarial-plan-reviewer/plan-reviewer(Phase 3½): AuditsPLAN.mdagainst the Product/Brief/Design sources and blocks plans missing measurable acceptance criteria or mounted runtime entry points.comprehensive-code-review&code-quality-reviewer(Phase 8): Requires reviewers to read the plan, brief, and approved UI design alongside the diff, emit a mandatory### Acceptance Criteria & Design Target Audittable (PASS/FAILwithfile:lineruntime wiring evidence), and flag "test-only / dead-wiring theater" (isolated helpers tested in unit tests without mounting in the runtime component tree), missing breakpoint/header/nav parity, missing animations, or truncated assets asCRITICAL/Blocking.Background Context
Code reviews previously focused only on code-level correctness and security within the diff without verifying whether the change actually delivered the phase's stated product goals, Point-of-View Brief rules, or approved UI design targets in the mounted runtime app.
Test Plan
python3 internal/catalog/shared/skills/future-skill-creator/scripts/quick_validate.py internal/catalog/shared/skills/future-writing-planspython3 internal/catalog/shared/skills/future-skill-creator/scripts/quick_validate.py internal/catalog/antigravity/skills/future-writing-planstest -z "$(gofmt -l .)" && go vet ./... && go test -count=1 ./...Rollback Plan
Revert the merge commit with
git revert <sha>.