Skip to content

feat(skills): rename writing-plans to future-writing-plans and enforce acceptance-criteria review gates - #124

Merged
futuregerald merged 1 commit into
mainfrom
feat/future-writing-plans-and-acceptance-criteria-reviews
Nov 15, 2026
Merged

futuregerald merged 1 commit into
mainfrom
feat/future-writing-plans-and-acceptance-criteria-reviews

Conversation

@futuregerald

Copy link
Copy Markdown
Owner

Summary

  • Rename writing-plans → future-writing-plans (/future-writing-plans):
    • Renamed internal/catalog/shared/skills/writing-plans and internal/catalog/antigravity/skills/writing-plans to future-writing-plans.
    • Added author: Jesse Vincent, Gerald Onyango in YAML frontmatter, LICENSE.txt (MIT), and fork attribution footer crediting Jesse Vincent (obra/superpowers) and Gerald Onyango.
    • Updated internal/catalog/tracks.yaml, internal/catalog/catalog.go, scripts/sync-antigravity-from-local.sh, CLI/TUI tests, READMEs, harness templates (CLAUDE*, GEMINI*, AGENTS*), and all cross-referencing skills.
  • Enforce Product/Brief/Design Acceptance Criteria & Success Metrics Across Planning & Reviews:
    • future-writing-plans (Phase 3): Requires a Product & Design Sources section and a mandatory ## Acceptance Criteria & Success Metrics (Required Gate) table mapping every Phase Goal, Point-of-View Brief rule (docs/point-of-view/*.md), PRD/Decision (docs/prd.md, docs/decisions/*.md), and Approved UI Design (design-demos/*/direction-approved.md) to a measurable target and a mounted/wired runtime entry point (file:Symbol).
    • Mandatory User Approval Gate After Phase 3 (Plan): Enforces presenting the proposed plan and Acceptance Criteria in chat and stopping for user confirmation before Phase 4 implementation unless the user explicitly says "just work", "work autonomously", "keep going", or invokes /goal.
    • plan-review / adversarial-plan-reviewer / plan-reviewer (Phase 3½): Audits PLAN.md against the Product/Brief/Design sources and blocks plans missing measurable acceptance criteria or mounted runtime entry points.
    • comprehensive-code-review & code-quality-reviewer (Phase 8): Requires reviewers to read the plan, brief, and approved UI design alongside the diff, emit a mandatory ### Acceptance Criteria & Design Target Audit table (PASS / FAIL with file:line runtime wiring evidence), and flag "test-only / dead-wiring theater" (isolated helpers tested in unit tests without mounting in the runtime component tree), missing breakpoint/header/nav parity, missing animations, or truncated assets as CRITICAL / Blocking.

Background Context

Code reviews previously focused only on code-level correctness and security within the diff without verifying whether the change actually delivered the phase's stated product goals, Point-of-View Brief rules, or approved UI design targets in the mounted runtime app.

Test Plan

  • python3 internal/catalog/shared/skills/future-skill-creator/scripts/quick_validate.py internal/catalog/shared/skills/future-writing-plans
  • python3 internal/catalog/shared/skills/future-skill-creator/scripts/quick_validate.py internal/catalog/antigravity/skills/future-writing-plans
  • test -z "$(gofmt -l .)" && go vet ./... && go test -count=1 ./...

Rollback Plan

Revert the merge commit with git revert <sha>.

@futuregerald
futuregerald merged commit 8de3b0d into main Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant