fix(#8192): read mint_url from config.yaml/config.base.yaml in fullsend run by mfrancisc · Pull Request #8400 · fullsend-ai/fullsend

mfrancisc · 2026-10-13T15:39:08Z

Summary

fullsend run and the status-comment notifier never consulted config.yaml/config.base.yaml for mint_url — only --mint-url and FULLSEND_MINT_URL were read. This adds the file as a layer between them, so a repo can configure its mint endpoint via the layered config instead of only through the repository variable.

Related Issue

Fixes #8192

Changes

Add ConfigMintURLFromFile() to PerRepoConfigReader (internal/config/interfaces.go, internal/config/defaults.go): walks the overlay → base chain like ConfigMintURL(), but stops short of the compiled default (DefaultPerRepoMintURL). This lets callers tell "the file is silent" apart from "the file resolves to the hosted default."
Add resolveMintURL() in internal/cli/run.go with precedence: --mint-url flag > config.yaml/config.base.yaml mint_url > FULLSEND_MINT_URL > "".
Wire resolveMintURL() into runAgent() and setupStatusNotifierGitHub(), replacing the old flag-then-env-only resolution.
Deliberately preserve "narrow" behavior: when nothing sets mint_url anywhere, the resolved value stays "" and minting is skipped with a warning, exactly as before this change — it does not fall through to the compiled default https://mint.fullsend.sh. That default continues to apply only at install time (fullsend github setup/converge, via effectiveSetupMintURL()), which is unchanged.
Add an OIDC-availability downgrade in runAgent: a file-sourced mint_url with no FULLSEND_MINT_URL set, outside GitHub Actions (or with Actions OIDC env absent), downgrades to warn-and-skip instead of a hard failure, since minting would otherwise attempt and fail a GitHub Actions OIDC exchange that is unavailable locally.

Scope / follow-up

This PR's live-dispatch effect is not uniformly zero, and is narrower than "none" — see review discussion:

Most dispatched stages (triage, code, review, fix, retro, harness-run) still pass mint-url built from the FULLSEND_MINT_URL repository variable, which wins over the file via the flag. No observable change there until the route job is taught to compute an effective mint URL from a trusted config checkout (follow-up PR, needs workflows write permission a code agent doesn't have).
The prioritize paths (reusable-prioritize.yml and the inlined prioritize job in reusable-dispatch.yml) have no upfront mint-token step gating on that variable, and action.yml omits --mint-url entirely when its input is empty (rather than passing an empty value). So when FULLSEND_MINT_URL is unset but mint_url is set in config.yaml/config.base.yaml, fullsend run (and the status notifier, since these jobs set status-repo/status-number) now mint for real from the file's endpoint, inside a real Actions run with working OIDC — a live change today, on this one path. The same applies to any other composite-action caller that leaves mint-url empty. This is very likely the intended outcome of mint_url in .fullsend/config.yaml does not reach workflows or fullsend run #8192 for that path, and is not a trust concern (.fullsend is checked out at a pinned base SHA), but it was undocumented. If the endpoint configured via the file does not serve the prioritize role, a prioritize run that previously skipped minting and used the workflow token will now fail instead.

Confirming that the mint endpoint serves the prioritize role wherever mint_url is file-only, and adding dedicated coverage for that path, is tracked as follow-up — not yet done in this PR. The docs/contributing/config-source-inventory.md mint_url row has been updated to describe this accurately.

Testing

make lint passes (stage changes first, then run)
Tests added/updated for new or modified logic
- internal/config: ConfigMintURLFromFile overlay-wins, base-only fallback, and neither-set-divergence-from-ConfigMintURL cases
- internal/cli: file-wins-over-env, base-file-wins-over-env, and flag-still-wins-over-file cases for both runAgent and setupStatusNotifierGitHub; confirmed existing TestRunAgent_WarnsWhenNoMintURL, TestRunAgent_FallsBackToFULLSEND_MINT_URL, TestMintAgentToken_SkipsWhenNoMintURL, TestSetupStatusNotifier_NoMintURL, TestRunAgent_MintsRuntimePrivilegeLevel remain green and unmodified

Context

partof the broader AISDLC-144 configuration-alignment effort

…l in fullsend run Signed-off-by: fmuntean <fmuntean@redhat.com>

github-actions · 2026-10-13T15:39:20Z

E2E tests did not run

E2E tests run automatically for pull requests authored by users with write access or higher.

For other contributors, someone with write access must add the ok-to-test label after the latest push.

Reason: unauthorized

See E2E testing guide for details.

qodo-code-review · 2026-10-13T15:39:55Z

PR Summary by Qodo

Read layered mint_url configuration during fullsend run

🐞 Bug fix 🧪 Tests 🕐 20-40 Minutes

AI Description

• Read mint_url from layered config before FULLSEND_MINT_URL for agent runs and GitHub status
 comments.
• Preserve flag precedence and skip minting when no runtime URL is configured.
• Add precedence and fallback tests; dispatched workflows still require a follow-up change.

Diagram

graph TD
  Flag["--mint-url flag"] --> Resolver["URL resolver"] --> Agent["Agent run"] --> Mint["Mint service"]
  File["Overlay / base"] --> Resolver --> Notifier["GitHub notifier"] --> Mint
  Env["FULLSEND_MINT_URL"] --> Resolver

High-Level Assessment

Keep the shared CLI resolver and file-only accessor. Reusing ConfigMintURL would silently introduce the compiled default into runtime minting; resolving only in workflows would not fix local CLI runs. The separate workflow change remains necessary because dispatched stages currently pass an overriding flag.

Files changed (7) +333 / -11

Bug fix (3) +59 / -11

run.goResolve runtime mint URLs from flag, layered config, then environment +32/-11

Resolve runtime mint URLs from flag, layered config, then environment
• Adds a shared resolver for agent runs and GitHub status notifications. It preserves the empty-URL behavior when no runtime source supplies a value.
internal/cli/run.go

defaults.goStop file-only mint URL lookup at compiled defaults +5/-0

Stop file-only mint URL lookup at compiled defaults
• Implements ConfigMintURLFromFile on the defaults layer as an empty value, distinct from the hosted URL returned by ConfigMintURL.
internal/config/defaults.go

interfaces.goExpose file-only layered mint URL lookup +22/-0

Expose file-only layered mint URL lookup

• Extends PerRepoConfigReader with ConfigMintURLFromFile. The implementation searches the overlay and parent chain without substituting the compiled default.

internal/config/interfaces.go

Tests (4) +274 / -0

run_test.goTest runtime mint URL precedence +196/-0

Test runtime mint URL precedence

• Adds agent-run coverage for overlay and base-file values outranking the environment, and for the flag outranking the file. Adds GitHub status-notifier coverage for a file value outranking the environment.

internal/cli/run_test.go

defaults_test.goVerify defaults do not supply a file-only mint URL +2/-0

Verify defaults do not supply a file-only mint URL
• Asserts that direct defaults and an empty per-repo config return no file-only mint URL while retaining the compiled ConfigMintURL default.
internal/config/defaults_test.go

interfaces_test.goTest overlay precedence and file-only fallback +34/-0

Test overlay precedence and file-only fallback
• Covers parent fallback, local override, and the distinction between an unset file value and the compiled ConfigMintURL default.
internal/config/interfaces_test.go

load_test.goTest file-only mint URLs through config loading +42/-0

Test file-only mint URLs through config loading
• Checks overlay and base-file lookup after loading layered config, plus the empty result when neither file sets mint_url.
internal/config/load_test.go

fullsend-ai-review · 2026-10-13T15:41:14Z

🤖 Finished Review · ✅ Success · Started 3:41 PM UTC · Completed 3:51 PM UTC

Commit: 295b10b · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.72

qodo-code-review · 2026-10-13T15:46:26Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. ~~Run docs omit file mint settings~~ ✓ Resolved

Description

resolveMintURL changes fullsend run and the status notifier to consult layered mint_url before
FULLSEND_MINT_URL, but the PR updates no affected documentation. The config-source inventory still
says runs use only the flag and environment variable, so users and maintainers cannot discover or
verify the new file-based precedence.

Code

internal/cli/run.go[R6549-6558]

+func resolveMintURL(flagValue string, orgCfg config.ConfigReader, getenv func(string) string) string {
+	if flagValue != "" {
+		return flagValue
+	}
+	if prc, ok := orgCfg.(config.PerRepoConfigReader); ok {
+		if u := prc.ConfigMintURLFromFile(); u != "" {
+			return u
+		}
+	}
+	return getenv("FULLSEND_MINT_URL")

Relevance

●●● Strong
Recent reviews accept updating user-facing docs when CLI configuration precedence or layered config
behavior changes.
PR-#7476
PR-#5976

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The documentation checklist requires every referenced configuration or environment-variable document
to be updated when behavior changes, and specifically requires the canonical config reference plus
layered-config documentation when layered resolution changes. The PR adds the file layer in
resolveMintURL, while the source inventory still documents flag-then-environment precedence and
the related configuration references retain the old default-only description.
Rule 2748504: Update docs/ references when changing user-facing behavior
Rule 2806787: Update CLI-related docs according to docs/contributing/documentation.md when changing CLI surface
internal/cli/run.go[6549-6558]
docs/contributing/documentation.md[20-27]
docs/contributing/config-source-inventory.md[113-113]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR changes the precedence and source of the `mint_url` configuration used by `fullsend run` and the status notifier, but the related documentation still describes the previous flag-and-environment-only behavior.

## Fix Focus Areas
- docs/contributing/config-source-inventory.md[113-113]
- docs/reference/config-reference.md[267-275]
- docs/guides/infrastructure/layered-config-reference.md[230-245]

## Recommended Fix
Update the mint URL documentation to state the actual precedence: `--mint-url`, layered `config.yaml`/`config.base.yaml` `mint_url`, `FULLSEND_MINT_URL`, then no URL for the run path. Clarify that the compiled hosted default remains an install-time default and is not used by `fullsend run` when no runtime source sets the value.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. CLI changes lack a required end-to-end gate 📘 Rule violation ▣ Testability

Description

The internal/cli/run.go changes have no documented make e2e-test execution or passing result in
the PR description. Although CI defines a related behaviour suite, the available evidence does not
show that the required end-to-end check ran successfully for this commit before merge.

Code

internal/cli/run.go[R872-875]

+	// Precedence: flag > config.yaml/config.base.yaml mint_url > env (#8192).
+	mintURL := resolveMintURL(sOpts.mintURL, orgCfg, os.Getenv)
	runtimeLevel := h.PrivilegeLevelForStage(harness.PrivilegeStageRuntime)
	var minted bool

Relevance

●●● Strong
Recent history accepts explicit E2E gating and documentation for CLI paths covered by the behavior
workflow.
PR-#2793
PR-#2277

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The PR modifies internal/cli/run.go, which is within the paths covered by the end-to-end testing
rule. The PR description lists lint and unit-test-related checks but does not state that `make
e2e-test passed, while the repository workflow invokes make behaviour-test` instead; no passing
result for the latest commit is available.
Rule 1062051: Run end-to-end tests for critical internal modules before merge
internal/cli/run.go[872-875]
.github/workflows/e2e.yml[186-194]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Changes under `internal/cli/` require evidence that the end-to-end test suite ran successfully before merge, but the PR description does not record a passing `make e2e-test` run and no latest-commit result is provided.

## Fix Focus Areas
- internal/cli/run.go[872-875]
- .github/workflows/e2e.yml[186-194]

## Recommended Fix
Run the repository's current end-to-end target for this change and record the successful result in the PR description, or ensure the equivalent CI behaviour-test job is a required status check that runs for `internal/cli/` changes and passes before merge.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

3. ~~Base-only repos lose status notifications~~ ✓ Resolved

Description

setupStatusNotifier passes a config loaded by tryLoadFullsendConfig to the new mint URL
resolver, but that loader returns nil when config.yaml is absent even if config.base.yaml
exists. For a base-only repository with mint_url in the base file and no flag or environment
value, the agent can load the base URL while notifier setup reports that no mint URL is available
and disables status comments.

Code

internal/cli/run.go[R6117-6118]

+func setupStatusNotifierGitHub(notifyCfg config.StatusNotificationConfig, orgCfg config.ConfigReader, owner, repo, role string, sOpts statusOpts, printer *ui.Printer) (*statuscomment.Notifier, error) {
+	mintURL := resolveMintURL(sOpts.mintURL, orgCfg, os.Getenv)

Relevance

●●● Strong
Recent precedent accepts fixing loaders that skip base-only configuration, matching this notifier
failure mode.
PR-#8088

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The notifier passes the result of tryLoadFullsendConfig into resolveMintURL, but that loader
returns nil on a missing overlay before it can read the base file. The runtime loader accepts a
base-only configuration; without a notifier config, the resolver falls back to the environment and
an empty result causes notifier setup to fail.
internal/cli/run.go[6082-6118]
internal/cli/orgconfig.go[16-29]
internal/cli/lock.go[151-178]
internal/cli/run.go[6549-6558]
internal/cli/run.go[1270-1278]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The status notifier cannot read `mint_url` from a base-only configuration because its config loader requires `config.yaml` to exist. This disables status comments when the URL is set only in `config.base.yaml` and no flag or environment value is available.

## Fix Focus Areas
- internal/cli/run.go[6082-6118]
- internal/cli/orgconfig.go[16-29]
- internal/cli/lock.go[151-178]

## Recommended Fix
Load the notifier's configuration through a path that accepts either config layer, as `loadLockConfig` does, while retaining the notifier's best-effort warning behavior for malformed configuration. Add a notifier test with only `config.base.yaml` present and its `mint_url` set.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Context sources

✅ Tickets: 🎫 mint_url in .fullsend/config.yaml does not reach workflows or fullsend run 🎫 dispatch: kill_switch check on GitHub and GitLab ignores config.base.yaml

✅ Compliance rules (platform): 89 rules

✅ Skills: 5 invoked

writing-user-docs

writing-adrs

check-patch-coverage

cutting-releases

adr-corner

✅ Cross-repo context — repo relationships

Explored: repo: fullsend-ai/.fullsend (sha: 7c163cad) — View relationship

Explored: repo: fullsend-ai/agents (sha: e0166257) — View relationship

Review mode: Auto: ⚖️ Balanced: Behavioral mint URL precedence affects token minting across multiple CLI paths.

Tip of the day

💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

qodo-code-review · 2026-10-13T15:46:27Z

+	// Precedence: flag > config.yaml/config.base.yaml mint_url > env (#8192).
+	mintURL := resolveMintURL(sOpts.mintURL, orgCfg, os.Getenv)
 	runtimeLevel := h.PrivilegeLevelForStage(harness.PrivilegeStageRuntime)
 	var minted bool


1. Cli changes lack a required end-to-end gate 📘 Rule violation ▣ Testability

The internal/cli/run.go changes have no documented make e2e-test execution or passing result in the PR description. Although CI defines a related behaviour suite, the available evidence does not show that the required end-to-end check ran successfully for this commit before merge.

Agent Prompt

## Issue description Changes under `internal/cli/` require evidence that the end-to-end test suite ran successfully before merge, but the PR description does not record a passing `make e2e-test` run and no latest-commit result is provided. ## Fix Focus Areas - internal/cli/run.go[872-875] - .github/workflows/e2e.yml[186-194] ## Recommended Fix Run the repository's current end-to-end target for this change and record the successful result in the PR description, or ensure the equivalent CI behaviour-test job is a required status check that runs for `internal/cli/` changes and passes before merge.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

codecov · 2026-10-13T15:47:21Z

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/config/interfaces.go	83.33%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

fullsend-ai-review · 2026-10-13T15:51:41Z